DAT 3464 #166
Closed
DAT 3464 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvoxland
approved these changes
Dec 17, 2019
SteveDonie
reviewed
Dec 17, 2019
| int index = checkArg(args[i]); | ||
| if (index >= 0) { | ||
| String message = | ||
| "Invalid, non-printable character detected in command line at position " + |
There was a problem hiding this comment.
Should mention the code point in the message for easier debugging. "Invalid, non printable character #${index} detected in command line..."
There was a problem hiding this comment.
Oops - just realized the return value is the index where the character is found, not which character was found. Could change the logic of checkArg to return a struct with both values - what was found and where.
|
@wwillard7800 ~ Can a unit test be provided to cover this code to assert that valid characters are not interfered with and invalid characters are removed as expected? |
SteveDonie
approved these changes
Dec 18, 2019
|
Merged in as liquibase#955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.