Upgrade FastAPI to the latest version by pinning it to >=0.110.0 #943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR takes the opportunity to upgrade DJ to the latest version of FastAPI. We're doing this because a number of updates to newer versions of FastAPI may fix the deadlock issue we were seeing with database sessions using
Depends
, namely this fix in0.82.0
:This is preferable to rolling our own solution.
The primary changes in this PR are to accommodate the new starlette
TestClient
, which useshttpx
rather thanrequests
. There are also a few changes needed for the updated version of pydantic (although no breaking changes as we haven't upgraded to pydantic>=2).Test Plan
Will update as tests are done.
make check
passesmake test
shows 100% unit test coverageDeployment Plan
ASAP