Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-3937] Replace Dogstatsd library version to work with amazon linux #693

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

AliDatadog
Copy link
Contributor

@AliDatadog AliDatadog commented Mar 18, 2024

What does this PR do?

This PR replaces the dogstasd version to run with DataDog/datadog-go#304.
It fixes origin detection on Amazon Linux ECS Optimized

Which scenarios this will impact?

all using dogstatsd

Motivation

Additional Notes

From my test, the containerid is now retrieved properly. I used a modified dogstatsd app that prints the content of the message:

[ec2-user@ip-10-1-56-42 ~]$ k -n workload-dogstatsd logs dogstatsd-udp-origin-detection-85b7dd9944-flk4c
2024/03/18 11:39:50 page.views:1|c|c:27b8312e67ae6bf568fdd350d44009785d07916bd3d115fb9f8d0fb6fba313c5

[ec2-user@ip-10-1-56-42 ~]$ k -n workload-dogstatsd get pod dogstatsd-udp-origin-detection-85b7dd9944-flk4c -o yaml | grep -i 27b8312
  - containerID: containerd://27b8312e67ae6bf568fdd350d44009785d07916bd3d115fb9f8d0fb6fba313c5

@AliDatadog AliDatadog requested a review from a team as a code owner March 18, 2024 11:49
@AliDatadog AliDatadog changed the title Replace Dogstatsd version to work with amazon linux [CONTINT-3937] Replace Dogstatsd library version to work with amazon linux Mar 18, 2024
@AliDatadog AliDatadog merged commit a86e6a0 into main Mar 28, 2024
17 checks passed
@AliDatadog AliDatadog deleted the ali/add-dsd-fix branch March 28, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants