Fix docs with high level of nesting and mark ID attribute as read only #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zippolyte
changed the title
nmuesch
approved these changes
Apr 22, 2021
zippolyte
added a commit
that referenced
this pull request
Apr 30, 2021
* Fix datadog security monitoring default rule (#956) * Fix typo from cases to case * Do not persist state changes when modifying bad rule case * Update default rule case notifications * align default rule case notification recipients when rule case tracked in terraform configuration * clear default rule case notification recipients when rule case removed from terraform configuration * Remove broken tests It is not possible to use both ImportState: True and Check * Revert "Remove broken tests" This reverts commit fed89bf. * Reapply test changes, re-record * Lint Co-authored-by: Alexandre Trufanow <alexandre.trufanow@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Fix timeseries tests (#979) Don't use removed metric * Add support for dashboard json resource (#950) * add dashboard_json resource * refactor and use client exported request methods * lint and move helper functions to util * lint * handle diffs on computed fields * normalize json string * add tests and refactor * update go client * lint * update tests and lint * apply code review requested changes * apply code review suggestions and re-record cassettes * generate resource docs * fmt * use mutex to only operate on one reosurce at a time (#981) * [dashboard datasource] Retry on 504 errors (#975) * [dashboard datasource] Retry on 504 errors * Use TimeoutRead instead of TimeoutCreate Signed-off-by: Jared Ledvina <jared@techsmix.net> * Changelog for 2.23.0 (#986) * Add datadog_metric_tag_configuration resource (#960) * initial commit for metric tag configuration resource * fixed build update to properly check metric_type before setting include_percentiles * added first pass on tests for tag config resource * added first pass on example for tag config resource * changes to upgrade client to master * fmt example * fixed tag config schema and use proper id for api calls * use proper provider for test * capitalize test func name * enable unstable endpoints, remove prints, use proper id for state, check include_percentiles * add remaining diff from master merge in * cleanup comment and imports * golint * fix test to use proper metric_name * fix existing tag config check * cassettes * updated cassettes * updated cassettes and import test name * removed old cassettes * cleanup comments and unneeded changes * dont include percentiles in example * added customizeDiff function for include_percentiles option * removed completed todos * fix error message * fix error message * updated example metric name and generated docs * updated cassettes * fix cassettes for import test * update docs * update doc comment * added examples and updated docs * update description, check status code for update * update test check to check status code * update docs * added error test and cassette * updated import cassette * updated basic cassette * check status code when importing tag configuration * added test invalid import ID, update cassettes * added metrics-agg as codeowner * changes from 1st round of PR comments, first pass at handling [] tags * update import cassette * update basic cassette * change regex, change validation to use all function * tests: use DD_INSIDE_CI env (#990) * Add legend_layout and legend_columns to timeseries widget definition [VIZZ-1207] (#992) * Add legend_layout and legend_columns to timeseries widget def * Update timeseries widget tests * Update go deps * Record cassettes * Remove other updates * Remove unwanted cassettes changes * Make docs * Update to latest commit * List enum values in legend_layout description * add missing enum description * Make legend_columns a TypeSet * Use TypeSet properly, fix tests * Update docs Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Update go client (#998) Use released version * Prepare release (#999) * Cleanup imports (#1000) * cleanup imports * cleanup imports on all resources and tests * Add support for `global_time_target` for SLO widgets (#1003) * add support for global_time_target * regenerate docs * Use goimports instead of gofmt (#1001) * use goimports instead of fmt * use format-only * [Synthetics] Prevent certificate update with wrong value (#997) * [Synthetics] Prevent certificate update with wrong value * [Synthetics] Improve hash detection * [Feature] Add datadog default security monitoring rule filters (#965) * [Feature] Add datadog default security monitoring rule filters * review * Add group_by block to logs_metric example (#1010) * [datasource dashboard] Retry on 502s (#1006) Signed-off-by: Jared Ledvina <jared@techsmix.net> * Add `noSavingResponseBody` and `noScreenshot` fields to Synthetics (#1012) * Update go client * [Synthetics] Add new fields to synthetics options * [Synthetics] Remove option * [Synthetics] Fix cassettes * [Synthetics] Fix missing doc * Remove read from monitor creation (#1015) Remove the read to improve consistency and update the state directly instead. * Set ForceNew to true on non-updatable GCP resource fields (#1013) * recreate GCP resource if certain fields are updated * lint * re-record cassettes * Set ForceNew to true for client_email as well * Fix panic when converting synthetics params (#1014) If params is empty, then we fail to parse the map and it ends up in a panic. * [slack integration] Set account_name in state (#1019) * [slack integration] Set account_name in state Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com> * [slack integration] Get account name from state instead of arg Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com> * add test case for import Co-authored-by: Sherzod K <sherzod.karimov@datadoghq.com> * [Synthetics] Use new models for api tests (#1005) * [Synthetics] Use new synthetics test objects * [Synthetics] Use new endpoint to read api tests * [Synthetics] Record new cassettes for new api endpoint * Update go client * [Synthetics] Update for correct browser test * [Synthetics] Fix review * [Synthetics] Fix cassette * Fix monitor restricted_roles diff (#1011) It shouldn't check for locked, as it's still present in the state, and thus remove the possibility of updating it. * Add support for multistep synthetics API tests (#1007) * [Synthetics] Add support for multistep tests * [Synthetics] Review fixes * [Synthetics] Update docs * [Synthetics] Remove comments * [Synthetics] Small fixes for synthetics (#1020) * [Synthetics] Small fixes for synthetics * [Synthetics] Generate docs * [Synthetics] Fix cassettes * [dashboards] Formula and Function support for Timeseries Widgets in Dashboard resource (#892) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * remove trailing * Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Remove MaxItems:1 restriction for group_by and compute properties * Add comments for ValidateStringValue * Fix reference to import in timeseries test * Add enum validation for timeseries formula and functions * Add two more validators Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> * Expose doc for SLO Corrections (#1021) * add an example for slo correction * add generated md file * correct a sentence * update message * update go client and fix slo (#1026) * prepare release (#1027) * Ignore widget IDs for diff on dashboard JSON resource (#1028) * Ignore widget IDs for diff on dashboard JSON resource * cassettes * [dashboards] Formula and Function support for Query Value Widgets in Dashboard resource (#953) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * remove trailing * Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Remove MaxItems:1 restriction for group_by and compute properties * Implement formulas and functions support for query value widgets * Implement validator for search.query * Pull in latest validators * Remove duplicated variable Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> * [msl] Add reflow_type property for dashboards (#1017) * Add dashboard reflow_type property * update reflow type doc * Update dashboard doc * [dashboards] Formula and Function support for Toplist Widgets in Dashboard resource (#951) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * remove trailing * Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Implement ability to create toplists with formulas and functions * Implement tests for toplist formulas and functions * Prevent crashes when search.query is an empty string * Fix search.query empty strings causing perpetual diffs * Implement validator for search.query * Pull out terraform search * Formatting * Remove duplicate declarations in tests * Remove duplicate datadogDashboardFormulaConfig * Update toplist test for new search.query syntax * Update toplist test for new search.query syntax * Record new cassettes for formulas and functions toplist * Record new cassettes for classic toplist Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> * Fix docs with high level of nesting and mark ID attribute as read only (#1036) * Fix docs with high level of nesting * include ID fix * 3rd party * Properly mark `active`/`disabled` fields as readonly to avoid diffs (#1034) * Properly mark `active`/`disabled` fields as readonly to avoid diffs * fix test * record' ' * docs * [monitor resource] Retry on 504 (#1038) Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com> * datadog_metric_tag_configuration remove blocking tests (#1037) * remove broken tests * removed old cassettes * [dashboards] Implement formulas and functions for geomap widgets (#1043) * Implement security queries and formulas and functions for geomap widgets * Remove security query track for geomap widgets * Update cassettes * Add new tests for security_signals track for geomap * Generate new cassettes * Generate new cassettes * Re-record Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Update go-client and use new api models (#1041) * update go-client and use new api models * Bump datadog api client to latest release * use correct Destroy method for slack import test (#1032) * [Synthetics] Add support for icmp tests (#1030) * Mark AWS account as non existent if GET returns 400 when AWS integration not installed (#1047) * remove duplicate value * fix test and record Co-authored-by: Alexej Tessaro <rymir@users.noreply.github.com> Co-authored-by: Alexandre Trufanow <alexandre.trufanow@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Jared Ledvina <jared.ledvina@datadoghq.com> Co-authored-by: Eric Fraese <eric.fraese@datadoghq.com> Co-authored-by: Jiri Kuncar <jiri.kuncar@datadoghq.com> Co-authored-by: Abe Rubenstein <sighrobot@users.noreply.github.com> Co-authored-by: Romain Berger <romain.berger@datadoghq.com> Co-authored-by: Sherzod K <sherzod.karimov@datadoghq.com> Co-authored-by: David Leonard <david.leonard@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> Co-authored-by: Zhengshi Zhao <zhengshizhao@users.noreply.github.com> Co-authored-by: David Robert-Ansart <david.robertansart@datadoghq.com>
skarimo
added a commit
that referenced
this pull request
May 20, 2021
* Fix datadog security monitoring default rule (#956) * Fix typo from cases to case * Do not persist state changes when modifying bad rule case * Update default rule case notifications * align default rule case notification recipients when rule case tracked in terraform configuration * clear default rule case notification recipients when rule case removed from terraform configuration * Remove broken tests It is not possible to use both ImportState: True and Check * Revert "Remove broken tests" This reverts commit fed89bf. * Reapply test changes, re-record * Lint Co-authored-by: Alexandre Trufanow <alexandre.trufanow@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Fix timeseries tests (#979) Don't use removed metric * Add support for dashboard json resource (#950) * add dashboard_json resource * refactor and use client exported request methods * lint and move helper functions to util * lint * handle diffs on computed fields * normalize json string * add tests and refactor * update go client * lint * update tests and lint * apply code review requested changes * apply code review suggestions and re-record cassettes * generate resource docs * fmt * use mutex to only operate on one reosurce at a time (#981) * [dashboard datasource] Retry on 504 errors (#975) * [dashboard datasource] Retry on 504 errors * Use TimeoutRead instead of TimeoutCreate Signed-off-by: Jared Ledvina <jared@techsmix.net> * Changelog for 2.23.0 (#986) * Add datadog_metric_tag_configuration resource (#960) * initial commit for metric tag configuration resource * fixed build update to properly check metric_type before setting include_percentiles * added first pass on tests for tag config resource * added first pass on example for tag config resource * changes to upgrade client to master * fmt example * fixed tag config schema and use proper id for api calls * use proper provider for test * capitalize test func name * enable unstable endpoints, remove prints, use proper id for state, check include_percentiles * add remaining diff from master merge in * cleanup comment and imports * golint * fix test to use proper metric_name * fix existing tag config check * cassettes * updated cassettes * updated cassettes and import test name * removed old cassettes * cleanup comments and unneeded changes * dont include percentiles in example * added customizeDiff function for include_percentiles option * removed completed todos * fix error message * fix error message * updated example metric name and generated docs * updated cassettes * fix cassettes for import test * update docs * update doc comment * added examples and updated docs * update description, check status code for update * update test check to check status code * update docs * added error test and cassette * updated import cassette * updated basic cassette * check status code when importing tag configuration * added test invalid import ID, update cassettes * added metrics-agg as codeowner * changes from 1st round of PR comments, first pass at handling [] tags * update import cassette * update basic cassette * change regex, change validation to use all function * tests: use DD_INSIDE_CI env (#990) * Add legend_layout and legend_columns to timeseries widget definition [VIZZ-1207] (#992) * Add legend_layout and legend_columns to timeseries widget def * Update timeseries widget tests * Update go deps * Record cassettes * Remove other updates * Remove unwanted cassettes changes * Make docs * Update to latest commit * List enum values in legend_layout description * add missing enum description * Make legend_columns a TypeSet * Use TypeSet properly, fix tests * Update docs Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Update go client (#998) Use released version * Prepare release (#999) * Cleanup imports (#1000) * cleanup imports * cleanup imports on all resources and tests * Add support for `global_time_target` for SLO widgets (#1003) * add support for global_time_target * regenerate docs * Use goimports instead of gofmt (#1001) * use goimports instead of fmt * use format-only * [Synthetics] Prevent certificate update with wrong value (#997) * [Synthetics] Prevent certificate update with wrong value * [Synthetics] Improve hash detection * [Feature] Add datadog default security monitoring rule filters (#965) * [Feature] Add datadog default security monitoring rule filters * review * Add group_by block to logs_metric example (#1010) * [datasource dashboard] Retry on 502s (#1006) Signed-off-by: Jared Ledvina <jared@techsmix.net> * Add `noSavingResponseBody` and `noScreenshot` fields to Synthetics (#1012) * Update go client * [Synthetics] Add new fields to synthetics options * [Synthetics] Remove option * [Synthetics] Fix cassettes * [Synthetics] Fix missing doc * Remove read from monitor creation (#1015) Remove the read to improve consistency and update the state directly instead. * Set ForceNew to true on non-updatable GCP resource fields (#1013) * recreate GCP resource if certain fields are updated * lint * re-record cassettes * Set ForceNew to true for client_email as well * Fix panic when converting synthetics params (#1014) If params is empty, then we fail to parse the map and it ends up in a panic. * [slack integration] Set account_name in state (#1019) * [slack integration] Set account_name in state Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com> * [slack integration] Get account name from state instead of arg Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com> * add test case for import Co-authored-by: Sherzod K <sherzod.karimov@datadoghq.com> * [Synthetics] Use new models for api tests (#1005) * [Synthetics] Use new synthetics test objects * [Synthetics] Use new endpoint to read api tests * [Synthetics] Record new cassettes for new api endpoint * Update go client * [Synthetics] Update for correct browser test * [Synthetics] Fix review * [Synthetics] Fix cassette * Fix monitor restricted_roles diff (#1011) It shouldn't check for locked, as it's still present in the state, and thus remove the possibility of updating it. * Add support for multistep synthetics API tests (#1007) * [Synthetics] Add support for multistep tests * [Synthetics] Review fixes * [Synthetics] Update docs * [Synthetics] Remove comments * [Synthetics] Small fixes for synthetics (#1020) * [Synthetics] Small fixes for synthetics * [Synthetics] Generate docs * [Synthetics] Fix cassettes * [dashboards] Formula and Function support for Timeseries Widgets in Dashboard resource (#892) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * remove trailing * Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Remove MaxItems:1 restriction for group_by and compute properties * Add comments for ValidateStringValue * Fix reference to import in timeseries test * Add enum validation for timeseries formula and functions * Add two more validators Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> * Expose doc for SLO Corrections (#1021) * add an example for slo correction * add generated md file * correct a sentence * update message * update go client and fix slo (#1026) * prepare release (#1027) * Ignore widget IDs for diff on dashboard JSON resource (#1028) * Ignore widget IDs for diff on dashboard JSON resource * cassettes * [dashboards] Formula and Function support for Query Value Widgets in Dashboard resource (#953) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * remove trailing * Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Remove MaxItems:1 restriction for group_by and compute properties * Implement formulas and functions support for query value widgets * Implement validator for search.query * Pull in latest validators * Remove duplicated variable Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> * [msl] Add reflow_type property for dashboards (#1017) * Add dashboard reflow_type property * update reflow type doc * Update dashboard doc * [dashboards] Formula and Function support for Toplist Widgets in Dashboard resource (#951) * WIP * Finish formula and function metric_query * Implement most of FormulaAndFunctionProcessQuery * Update client * Ues new fields * Fix compute building * Implement a few more fields for formulas and functions event query * Add reading part * Persist data_source, compute, name and indexes to terraform state * Push changes for supporting search in formula and function event queries * Retrieve the query * Test skeleton * Implement more queries, tests * WIP group_by for EventQuery * Start working on adding formulas and event_query group_by * Update client * Fix formula support * Implement limit * Implement group_by schema for formula and function event query * Extend test suite for dashboard formula and functions * Add descriptions to all schema values for formulas and functions * Fix missing comma * More linting * Fix missing comma * Sync changes * Add missing functions * Update client * Exclude empty searches, update client * Add default to sort for matching SDK behavior * Merge with master * [screenboard] Fix outdated description (#904) Uptime widgets are no more. * Add security-monitoring team to codeowners (#869) * add security-monitoring team to codeownders * commit review changes Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * remove trailing * Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Stop using read handler in create/update (#905) * Address PR review comments from Nick * Move new cassettes to test folder * Code cleanup and doc generation * Revert doc changes for other resources * Revert last doc change * Replace timeseries formula and function methods with new generic names * Merge with master, remove references to TimeSeries specific formula and function objects * Modify test names for dashboard formulas and functions, regenerate cassettes * Remove tests with old names * Regenerate dashboard doc * Implement ability to create toplists with formulas and functions * Implement tests for toplist formulas and functions * Prevent crashes when search.query is an empty string * Fix search.query empty strings causing perpetual diffs * Implement validator for search.query * Pull out terraform search * Formatting * Remove duplicate declarations in tests * Remove duplicate datadogDashboardFormulaConfig * Update toplist test for new search.query syntax * Update toplist test for new search.query syntax * Record new cassettes for formulas and functions toplist * Record new cassettes for classic toplist Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: skarimo <40482491+skarimo@users.noreply.github.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> * Fix docs with high level of nesting and mark ID attribute as read only (#1036) * Fix docs with high level of nesting * include ID fix * 3rd party * Properly mark `active`/`disabled` fields as readonly to avoid diffs (#1034) * Properly mark `active`/`disabled` fields as readonly to avoid diffs * fix test * record' ' * docs * [monitor resource] Retry on 504 (#1038) Signed-off-by: Jared Ledvina <jared.ledvina@datadoghq.com> * datadog_metric_tag_configuration remove blocking tests (#1037) * remove broken tests * removed old cassettes * [dashboards] Implement formulas and functions for geomap widgets (#1043) * Implement security queries and formulas and functions for geomap widgets * Remove security query track for geomap widgets * Update cassettes * Add new tests for security_signals track for geomap * Generate new cassettes * Generate new cassettes * Re-record Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Update go-client and use new api models (#1041) * update go-client and use new api models * Bump datadog api client to latest release * use correct Destroy method for slack import test (#1032) * [Synthetics] Add support for icmp tests (#1030) * Mark AWS account as non existent if GET returns 400 when AWS integration not installed (#1047) * Add SLO datasources (#931) * Add SLO datasources Closes #911 Signed-off-by: Adrien FILLON <adrien.fillon@manomano.com> * rebase on master * remake docs * fix up tests * record Co-authored-by: Hippolyte HENRY <hippolyte.henry@datadoghq.com> * [Dashboards] Add new properties to group widget, note widget and image widget (#1044) * Add is_column_break layout property * Add new group properties * Add image new options * Add new note properties * Improve group background color description * update go client * Fix linter error * Generate new cassettes * make doc * Add support for `setCookie`, `dnsServerPort`, `allowFailure` and `isCritical` fields for Synthetics tests (#1052) * Update go client * [Synthetics] Add support for new fields * [Synthetics] Remove useless request options for browser tests * [Synthetics] Regenerate docs * Update monitor `critical` threshold documentation (#1055) * Update monitor.md Under the schema for `monitor_thresholds`, `critical` is listed as the "recovery threshold" rather than "threshold". * Update schema Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Add monitors datasource for multiple monitors (#1048) * Add monitors datasource for multiple monitors * docs * review * Use code formatting in description for attribute remapper (#1061) * Use custom transport for HTTPClient (#1054) * use custom transport for HTTPClient * use response retry header for retry duration * put http retry behind provider configuration option * handle nil transport * remove custom client from test provider * add test provider client wrapper * lint * Handle nil responses * add docs * fix clientv2 transport * Apply code review suggestions * make docss * fix flaky slo test Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Use mutex to sync logs custom pipeline (#1069) * Update Datadog api go client (#1064) * Update go client to use latest release Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> * Prepare release of 2.26.0 (#1071) * Prepare 2.26.0 release * fix failing tests * make docs * remove deprecated field options from synthetics * re-record slo datasource cassettes Co-authored-by: Alexej Tessaro <rymir@users.noreply.github.com> Co-authored-by: Alexandre Trufanow <alexandre.trufanow@datadoghq.com> Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: Jared Ledvina <jared.ledvina@datadoghq.com> Co-authored-by: Hippolyte HENRY <zippolyte@users.noreply.github.com> Co-authored-by: Eric Fraese <eric.fraese@datadoghq.com> Co-authored-by: Jiri Kuncar <jiri.kuncar@datadoghq.com> Co-authored-by: Abe Rubenstein <sighrobot@users.noreply.github.com> Co-authored-by: Romain Berger <romain.berger@datadoghq.com> Co-authored-by: David Leonard <david.leonard@datadoghq.com> Co-authored-by: Phillip Baker <59581508+phillip-dd@users.noreply.github.com> Co-authored-by: Nicholas Muesch <nicholas.muesch@datadoghq.com> Co-authored-by: Zhengshi Zhao <zhengshizhao@users.noreply.github.com> Co-authored-by: David Robert-Ansart <david.robertansart@datadoghq.com> Co-authored-by: Adrien F <adrien.fillon@gmail.com> Co-authored-by: Hippolyte HENRY <hippolyte.henry@datadoghq.com> Co-authored-by: Toj Fowler <toj@jasonfowler.com> Co-authored-by: Murukesh Mohanan <83797086+murukesh-mohanan-paidy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Fixes #947