Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto): handle V3 member metadata and empty owned partitions #9

Merged

Conversation

remicalixte
Copy link

@remicalixte remicalixte commented Feb 1, 2024

Testing

This is useful in a consumer group mixing sarama and ukcl members. The ukcl members include the newer fields to their metadata. If a sarama member is the leader, it cannot compute the assignment and the whole consumer group is stalled

Errors happening without the patch:
image
It's happening here:

members, err := join.GetMembers()

With patch, no errors in the logs anymore

image

Copy link

@niamster niamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Remi 🙇

@remicalixte remicalixte merged commit 7e11e54 into DataDog:dm/v1.30.1-patched Feb 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants