Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(consumer): support multiple balance strategies #8

Merged

Conversation

remicalixte
Copy link

Backport of IBM#2339

This is necessary to be able to migrate from an assignment strategy to another: it lets the consumers advertise a list of supported strategy so the group can choose one that is supported by all members.

A migration can be done as follows:

  • all members support the old strategy only
  • members are rolled out to add support for new strategy while keeping the old one
  • during the rollout the group picks the old strategy as it is the only one supported by every member
  • after the rollout, all members supports both strategy. The one chosen is based on the order in the config

dnwe and others added 2 commits December 1, 2023 12:17
…-balance-strategies

feat(consumer): support multiple balance strategies
Copy link

@aliceanran aliceanran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@remicalixte remicalixte merged commit c65f63a into DataDog:dm/v1.30.1-patched Dec 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants