Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates lombok dependency to remove need for tools.jar #423

Closed
wants to merge 1 commit into from

Conversation

scottopell
Copy link
Contributor

I reviewed the lombok changelog and I don't see anything that should cause issues (tested this locally as well).
The lombok issue that discusses this fix is a bit of a mess, but here it is.

Newer JDKs don't ship with tools.jar from what I understand, this should make it easier to work on this project with a wider variety of java dev environments

@scottopell
Copy link
Contributor Author

Can't remove this dependency, lombok is not the only codepath that utilizes tools.jar

[ERROR] /home/circleci/project/src/main/java/org/datadog/jmxfetch/AttachApiConnection.java:[37,40] package com.sun.tools.attach does not exist

See https://github.com/DataDog/jmxfetch/blob/master/src/main/java/org/datadog/jmxfetch/AttachApiConnection.java#L38

@scottopell scottopell closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant