Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade isort to 5.6.1 #7748

Closed
wants to merge 4 commits into from
Closed

Conversation

AlexandreYang
Copy link
Member

What does this PR do?

Upgrade isort to 5.6.1

Motivation

PyCQA/isort#1443 (comment)

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #7748 into master will decrease coverage by 0.67%.
The diff coverage is n/a.

Impacted Files Coverage Δ
datadog_checks_base/tests/test_pdhbasecheck.py 36.25% <0.00%> (-63.75%) ⬇️
datadog_checks_base/tests/test_winpdh.py 40.81% <0.00%> (-57.15%) ⬇️
datadog_checks_base/tests/test_wmisampler.py 43.93% <0.00%> (-56.07%) ⬇️
datadog_checks_base/tests/test_wmicheck.py 69.23% <0.00%> (-30.77%) ⬇️
...atadog_checks/ibm_mq/collectors/stats_collector.py 88.70% <0.00%> (-3.23%) ⬇️
datadog_checks_base/datadog_checks/base/ddyaml.py 59.70% <0.00%> (-1.50%) ⬇️
cassandra_nodetool/tests/conftest.py
solr/tests/common.py
rethinkdb/tests/conftest.py
rethinkdb/tests/assertions.py
... and 242 more

@@ -1,4 +1,5 @@
# (C) Datadog, Inc. 2018-present
# CHANGED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# CHANGED

Unless there is a reason for this line?

@AlexandreYang AlexandreYang deleted the alex/upgrade_isort_2020-10-08 branch October 13, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants