Collect metrics if a client token is available #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofek
force-pushed
the
ofek/v
branch
6 times, most recently
from
d2eac29
to
6085ead
Compare
Codecov Report
|
ofek
force-pushed
the
ofek/v
branch
2 times, most recently
from
7398634
to
9619bd8
Compare
ofek
force-pushed
the
ofek/v
branch
2 times, most recently
from
421747f
to
d0308cc
Compare
| tags = list(self._tags) | ||
| tags.extend(dynamic_tags) | ||
| for submit_function in submission_queue: | ||
| submit_function(tags=tags) |
There was a problem hiding this comment.
That's a more abstract logic but I don't think we can do better without adding more api calls. In any case that's 10 times better than the previous logic
| self.log.exception(msg) | ||
| raise ApiUnreachable | ||
| self.service_check(self.SERVICE_CHECK_CONNECT, self.CRITICAL, message=msg, tags=self._tags) | ||
| raise ApiUnreachable(msg) |
There was a problem hiding this comment.
If the Vault API fails here, we won't collect prometheus metrics. I'd say it's worth to catch the error and collect prometheus metrics as well.
There was a problem hiding this comment.
Would would the service check be if only a subset of calls succeed?
There was a problem hiding this comment.
That's fair, or else we can have one service check for the API and one for prometheus?
* Add audit, core, token, runtime metrics * add auth, WAL metric * Remove duplicate * add replication metrics pt1 * Add replication metrics and secrets engine metrics * Finish adding storage backend metrics * Fix metric type * Fix policy summary description * Fix typos * Keep capitalized secrets engines metrics
|
Fixed by #5224 |
FlorianVeaux
approved these changes
Dec 18, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Notes
Also, ensures consistent tags. Previously: