Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requests #2656

Merged
merged 1 commit into from Nov 28, 2018
Merged

Upgrade requests #2656

merged 1 commit into from Nov 28, 2018

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Nov 28, 2018

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #2656 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2656      +/-   ##
==========================================
+ Coverage   83.67%   83.81%   +0.14%     
==========================================
  Files         598      600       +2     
  Lines       35264    35321      +57     
  Branches     4262     4281      +19     
==========================================
+ Hits        29507    29606      +99     
+ Misses       4516     4460      -56     
- Partials     1241     1255      +14

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the hashes, but LGTM

@ofek ofek merged commit e6ed77e into master Nov 28, 2018
@ofek ofek deleted the ofek/ur branch November 28, 2018 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants