Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-7957] updating Network vendors #17569

Merged
merged 3 commits into from
May 21, 2024

Conversation

aliciascott
Copy link
Contributor

@aliciascott aliciascott commented May 14, 2024

What does this PR do?

Updating existing Network Vendors integrations pages to link back to the NDM Vendor profiles table.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aliciascott, I think in the README you will need the full URL (https://docs.datadoghq.com/network_monitoring/devices/#vendor-profiles) and not just the relative URL.

@aliciascott aliciascott requested a review from rtrieu May 21, 2024 17:03
@aliciascott
Copy link
Contributor Author

Hi @aliciascott, I think in the README you will need the full URL (https://docs.datadoghq.com/network_monitoring/devices/#vendor-profiles) and not just the relative URL.

Thanks @rtrieu I fixed those if you want to re review!

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@aliciascott aliciascott merged commit db6bf06 into master May 21, 2024
34 of 35 checks passed
@aliciascott aliciascott deleted the aliciascott/DOCS-7957-Network-vendor-updates branch May 21, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment