Add AWS Batch on ECS Fargate docs #17534
Conversation
fanny-jiang
added
documentation
integration/ecs_fargate
qa/skip-qa
fanny-jiang
changed the title
There was a problem hiding this comment.
LGTM — I pushed some formatting edits, moved some things around. I also added a link to https://docs.datadoghq.com/resources/json/datadog-agent-aws-batch-ecs-fargate.json (which does not yet exist). Ensure that this file gets added in the documentation repo before merging this PR.
I also created a preview branch: https://docs-staging.datadoghq.com/cswatt/preview_aws_batch/integrations/ecs_fargate
If you make any further changes to this PR and would like to preview them in staging, let me know and I'll rerun the preview job.
ecs_fargate/README.md
Outdated
| [59]: https://docs.aws.amazon.com/batch/latest/userguide/create-compute-environment.html | ||
| [60]: https://docs.aws.amazon.com/batch/latest/userguide/create-job-queue-fargate.html | ||
| [61]: https://docs.datadoghq.com/resources/json/datadog-agent-aws-batch-ecs-fargate.json | ||
| [62]: /containers/guide/aws-batch-ecs-fargate |
There was a problem hiding this comment.
I think this link may be causing the APW README deployment to fail; could you update or investigate this please?
Putting the assets/no-deploy label on this until thats resolved; but once thats fixed feel free to remove the label
There was a problem hiding this comment.
Yes, this link depends on the prior merging of DataDog/documentation#23187 — must merge that one before this one will work
There was a problem hiding this comment.
I'm not sure if hard relative links like that work at all? (I could definitely be misremembering)
There was a problem hiding this comment.
Ah good point, it'll work in the corpsite build but not if someone's just looking at github docs. I'll fix
mgarabed
removed
the
assets/no-deploy
What does this PR do?
Add documentation for AWS Batch on ECS Fargate
Motivation
Additional Notes
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged