Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #17427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #17427

wants to merge 1 commit into from

Conversation

mrdoggopat
Copy link
Contributor

edit the disclaimer on the requirements for the sidecar agent injection feature in EKS fargate

What does this PR do?

Edit this line under the admission controller from, "This feature requires Cluster Agent v7.52.0+ and the ECS Fargate integration."
This feature requires Cluster Agent v7.52.0+ and the EKS Fargate integration.

Motivation

Seems like this is a typo as ECS Fargate is not required for this to work.

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Changelog entries must be created for modifications to shipped code
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

edit the disclaimer on the requirements for the sidecar agent injection feature in EKS fargate
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants