Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade clickhouse-driver to 0.2.6 on Python 3 #15726

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Upgrade clickhouse-driver to 0.2.6 on Python 3 #15726

merged 1 commit into from
Aug 31, 2023

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Aug 31, 2023

Motivation

Newer versions of pip cannot understand ranges that erroneously include wildcards:

Collecting clickhouse-driver==0.2.3 (from datadog-clickhouse==3.0.0)
  Downloading clickhouse-driver-0.2.3.tar.gz (213 kB)
     -------------------------------------- 213.3/213.3 kB 4.3 MB/s eta 0:00:00
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'error'
  error: subprocess-exited-with-error

  python setup.py egg_info did not run successfully.
  exit code: 1

  [15 lines of output]
  C:\Users\ofek\AppData\Local\hatch\env\virtual\datadog-clickhouse\BSWKISFA\latest\Lib\site-packages\setuptools\config\setupcfg.py:293: _DeprecatedConfig: Deprecated config in `setup.cfg`
  !!

          ********************************************************************************
          The license_file parameter is deprecated, use license_files instead.

          By 2023-Oct-30, you need to update your project and remove deprecated calls
          or your builds will no longer be supported.

          See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
          ********************************************************************************

  !!
    parsed = self.parsers.get(option_name, lambda x: x)(value)
  error in clickhouse-driver setup command: 'python_requires' must be a string containing valid version specifiers; Invalid specifier: '>=3.4.*'
  [end of output]

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #15726 (7179305) into master (406072e) will not change coverage.
The diff coverage is n/a.

Flag Coverage Δ
clickhouse 95.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Test Results

  20 files    20 suites   6m 40s ⏱️
  14 tests   12 ✔️   2 💤 0
150 runs  120 ✔️ 30 💤 0

Results for commit 7179305.

@ofek ofek merged commit bb0b4e5 into master Aug 31, 2023
32 of 33 checks passed
@ofek ofek deleted the ofek/ucd branch August 31, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants