Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin click dependency #11744

Closed
wants to merge 3 commits into from
Closed

Pin click dependency #11744

wants to merge 3 commits into from

Conversation

mgarabed
Copy link
Member

@mgarabed mgarabed commented Mar 28, 2022

What does this PR do?

The click library changed their support for autocompletion, raising errors when trying to run any ddev commands: changelog here

This PR pins the version to <8.1 instead, until the proper support gets added.

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #11744 (e63621a) into master (d4db50a) will increase coverage by 0.00%.
The diff coverage is n/a.

Flag Coverage Δ
ambari 85.75% <ø> (ø)
avi_vantage 91.92% <ø> (ø)
calico 83.33% <ø> (ø)
cilium 75.34% <ø> (+0.93%) ⬆️
external_dns 89.09% <ø> (ø)
hazelcast 92.39% <ø> (ø)
ibm_i 80.65% <ø> (ø)
istio 77.46% <ø> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mgarabed
Copy link
Member Author

Superseded by #11746

@mgarabed mgarabed closed this Mar 29, 2022
@dd-devflow dd-devflow bot deleted the mg/pin-click branch February 7, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants