Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-7722 CI Visibility and Test Visibility Product Landing Page Edits #23064

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alai97
Copy link
Contributor

@alai97 alai97 commented May 8, 2024

What does this PR do? What is the motivation?

Now that we've separated CI Visibility into CI Pipeline Visibility and Test Visibility, it's time to distinguish the pipeline content from the test content on the product landing pages. We're scrubbing any mention of "tests" from CI Visibility, and making sure that information is covered on the Test Visibility landing page (along with an update to the language/options partial).

Merge instructions

  • Please merge after reviewing

Additional notes

@alai97 alai97 requested a review from KickingTheTV May 8, 2024 17:54
@alai97 alai97 requested review from a team as code owners May 8, 2024 17:54
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approving with a suggestion to break up a long sentence.

content/en/tests/_index.md Outdated Show resolved Hide resolved
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
content/en/continuous_integration/_index.md Outdated Show resolved Hide resolved
content/en/continuous_integration/_index.md Outdated Show resolved Hide resolved
content/en/tests/_index.md Outdated Show resolved Hide resolved
static/images/integrations_logos/junit_avatar.svg Outdated Show resolved Hide resolved
alai97 and others added 2 commits May 9, 2024 07:22
Co-authored-by: Nikita Tkachenko <121111529+nikita-tkachenko-datadog@users.noreply.github.com>
Copy link
Contributor

@KickingTheTV KickingTheTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM

But can we just make one change while we're here. For the test setup page where we have the table of features and compatibility, can we add a checkmark for Intelligent Test Runner for Ruby? We now support ITR for all languages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants