Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support go version to 1.16+ #14391

Merged
merged 2 commits into from Jun 23, 2022
Merged

Conversation

ajgajg1134
Copy link
Contributor

dd-trace-go now supports only the 3 latest go versions which is currently 1.16-1.18

What does this PR do?

Motivation

Additional Notes


Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

dd-trace-go now supports only the 3 latest go versions which is currently 1.16-1.18
@ajgajg1134 ajgajg1134 requested a review from a team as a code owner June 22, 2022 18:07
@github-actions github-actions bot added the tracing Content changed in the tracing folder label Jun 22, 2022
@github-actions
Copy link
Contributor

Preview links (active after the build_preview check completes):
https://docs-staging.datadoghq.com/andrew.glaude/update-go-supported/tracing/setup_overview/setup/go

Copy link
Contributor

@katiehockman katiehockman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documentation somewhere on what we have to update when we upgrade our version of Go every 6 months? (Assuming that there is something we have to do there)
It would be nice to include this doc as something that needs to be regularly updated.

@ajgajg1134
Copy link
Contributor Author

Is there documentation somewhere on what we have to update when we upgrade our version of Go every 6 months? (Assuming that there is something we have to do there) It would be nice to include this doc as something that needs to be regularly updated.

Good idea, I wasn't sure quite where to create the docs, so to start I've added a comment within the dd-trace-go README so anyone updating the documentation within our repository will be reminded to update the public docs as well: DataDog/dd-trace-go#1353

@jtappa jtappa merged commit ca09e63 into master Jun 23, 2022
@jtappa jtappa deleted the andrew.glaude/update-go-supported branch June 23, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracing Content changed in the tracing folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants