Add Rack to RSpec #625
Merged
Add Rack to RSpec #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
dev/testing
delner
force-pushed
the
refactor/add_rack_spec
branch
2 times, most recently
from
4660ad4
to
0e3deb0
Compare
delner
force-pushed
the
refactor/add_rack_spec
branch
from
0e3deb0
to
da77e22
Compare
|
@delner would you be interested to consider |
|
Yeah, this has come up before in #424 and I'd be willing to consider it for the sake of improving accuracy. Ideally such an implementation would take minimal changes and not require the use of any other libraries. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the Rack minitests to RSpec.