Make spec compatible with concurrent-ruby v1.1.x #607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v1.0.x requiring 'concurrent/future' would pull in all the bells and whistles necessary to execute futures. In newer versions of the gem requiring that gets you *only* the `Future` class. Instead we either need to set up the default executors ourselves, manually require and specify the executor we want, or just require `concurrent` to get everything all loaded and set up the way the gem authors intended. This commit takes the third option.
|
Thanks for the quick investigation on this! I arrived at the same conclusion as well and reported it to the gem authors on this issue. Sounds like 1.1.3 is out which resolves this issue. I think it'd be best to close this in favor of 1.1.3. We'd want to avoid loading all of concurrent-ruby anyways, and the new version seems to fix the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.0.x requiring 'concurrent/future' would pull in all the bells and whistles necessary to execute futures. In newer versions of the gem requiring that gets you only the
Futureclass.Instead one either needs to set up the default executors ourselves, manually require and specify the executor we want, or just require
concurrentto get everything all loaded and set up the way the gem authors intended. This commit takes the third option.