Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump cibuildwheel [backport 2.5] #8244

Merged
merged 1 commit into from
Feb 1, 2024
Merged

ci: bump cibuildwheel [backport 2.5] #8244

merged 1 commit into from
Feb 1, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 31, 2024

Backport f2dc31f from #8240 to 2.5.

Bump to the latest cibuildwheel to fix Windows builds.

See more about the issue: pypa/cibuildwheel#1740

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Bump to the latest cibuildwheel to fix Windows builds.

See more about the issue:
pypa/cibuildwheel#1740

## Checklist

- [x] Change(s) are motivated and described in the PR description
- [x] Testing strategy is described if automated tests are not included
in the PR
- [x] Risks are described (performance impact, potential for breakage,
maintainability)
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed or label `changelog/no-changelog` is set
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/))
- [x] Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))
- [x] If this PR changes the public interface, I've notified
`@DataDog/apm-tees`.
- [x] If change touches code that signs or publishes builds or packages,
or handles credentials of any kind, I've requested a review from
`@DataDog/security-design-and-guidance`.

## Reviewer Checklist

- [x] Title is accurate
- [x] All changes are related to the pull request's stated goal
- [x] Description motivates each change
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- [x] Testing strategy adequately addresses listed risks
- [x] Change is maintainable (easy to change, telemetry, documentation)
- [x] Release note makes sense to a user of the library
- [x] Author has acknowledged and discussed the performance implications
of this PR as reported in the benchmarks PR comment
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit f2dc31f)
@github-actions github-actions bot requested a review from a team as a code owner January 31, 2024 14:37
@github-actions github-actions bot added changelog/no-changelog A changelog entry is not required for this PR. CI labels Jan 31, 2024
@emmettbutler emmettbutler enabled auto-merge (squash) January 31, 2024 14:40
@pr-commenter
Copy link

pr-commenter bot commented Jan 31, 2024

Benchmarks

Benchmark execution time: 2024-01-31 15:42:08

Comparing candidate commit d144aa1 in PR branch backport-8240-to-2.5 with baseline commit de3b9e4 in branch 2.5.

Found 1 performance improvements and 5 performance regressions! Performance is the same for 189 metrics, 9 unstable metrics.

scenario:flasksimple-baseline

  • 🟥 max_rss_usage [+892.976KB; +1053.034KB] or [+2.534%; +2.988%]

scenario:flasksimple-debugger

  • 🟥 max_rss_usage [+919.511KB; +1065.410KB] or [+2.609%; +3.023%]

scenario:flasksimple-iast-get

  • 🟥 max_rss_usage [+835.175KB; +990.002KB] or [+2.368%; +2.807%]

scenario:flasksimple-profiler

  • 🟥 max_rss_usage [+0.918MB; +1.083MB] or [+2.603%; +3.071%]

scenario:flasksimple-tracer

  • 🟥 max_rss_usage [+0.906MB; +1.101MB] or [+2.570%; +3.123%]

scenario:span-add-metrics

  • 🟩 max_rss_usage [-22.109MB; -22.000MB] or [-35.296%; -35.123%]

@gnufede gnufede closed this Feb 1, 2024
auto-merge was automatically disabled February 1, 2024 16:30

Pull request was closed

@gnufede gnufede reopened this Feb 1, 2024
@gnufede gnufede enabled auto-merge (squash) February 1, 2024 16:30
@gnufede gnufede merged commit 0bb8661 into 2.5 Feb 1, 2024
10 checks passed
@gnufede gnufede deleted the backport-8240-to-2.5 branch February 1, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants