fix(propagation): filter out unsupported dd_origin values #6854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into situations where public clients were sending HTTP requests with unsupported non-ascii characters in the
x-datadog-origin
headers. These headers were being propagated, via theHTTPPropagator.extract
and gRPC client interceptor, to branching gRPC calls. The gRPC calls are then failing on the client side due to gRPC client side validation which forbids metadata values with non-ascii characters.The proposed solution here will prevent these unsupported headers values from being propagated by preventing them from being set within
Context
. This approach may impact HTTP propagation to branching HTTP requests, but my understanding is that non-ascii characters are not supported in these situations either.Checklist
changelog/no-changelog
.Reviewer Checklist
@DataDog/security-design-and-guidance
.