Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(riot): run tests with pytest latest #4846

Merged
merged 11 commits into from Jan 19, 2023

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Dec 30, 2022

Description

Run ddtrace test suite with pytest latest

@mabdinur mabdinur force-pushed the munir/debug-pytest-31-deadlocks branch from fe10502 to 03ee183 Compare December 30, 2022 07:19
@mabdinur mabdinur changed the base branch from 1.6 to 1.x December 30, 2022 07:20
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Dec 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #4846 (03ee183) into 1.x (ee03804) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              1.x    #4846      +/-   ##
==========================================
- Coverage   74.63%   74.63%   -0.01%     
==========================================
  Files         810      810              
  Lines       62277    62277              
==========================================
- Hits        46482    46479       -3     
- Misses      15795    15798       +3     
Impacted Files Coverage Δ
ddtrace/contrib/cassandra/session.py 86.74% <0.00%> (-1.11%) ⬇️
tests/utils.py 90.18% <0.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

riotfile.py Outdated Show resolved Hide resolved
@mabdinur mabdinur changed the title chore: pytest deadlocks in python 3.11 chore(ddtrace): enable ci visibility Dec 30, 2022
pytest.ini Outdated Show resolved Hide resolved
@mabdinur mabdinur force-pushed the munir/debug-pytest-31-deadlocks branch from 9cd164a to dd06e73 Compare December 30, 2022 16:42
@mabdinur mabdinur changed the title chore(ddtrace): enable ci visibility chore(ddtrace): enable ci visibility in tests Dec 30, 2022
@mabdinur
Copy link
Contributor Author

Enabling ci visibility will trace the execution of tests. Tests that use the global tracer to generate traces might be impacted.

setup.cfg Outdated Show resolved Hide resolved
@mabdinur mabdinur changed the title chore(ddtrace): enable ci visibility in tests ci: unpin pytest Jan 4, 2023
@mabdinur mabdinur changed the title ci: unpin pytest ci: use pytest latest in ci Jan 4, 2023
@mabdinur mabdinur marked this pull request as ready for review January 4, 2023 16:28
@mabdinur mabdinur requested a review from a team as a code owner January 4, 2023 16:28
@mabdinur mabdinur changed the title ci: use pytest latest in ci ci: run riot tests with pytest latest Jan 4, 2023
@ZStriker19
Copy link
Contributor

Could you add any further info as to why we weren't doing this before?

@mabdinur
Copy link
Contributor Author

mabdinur commented Jan 9, 2023

Could you add any further info as to why we weren't doing this before?

We pinned pytest in the follow PR to avoid this pytest-importlib incompatibility issue. pytest==7.0.1 resolved this issue.

@mabdinur mabdinur changed the title ci: run riot tests with pytest latest ci(riot): run tests with pytest latest Jan 12, 2023
@brettlangdon brettlangdon enabled auto-merge (squash) January 13, 2023 19:16
@brettlangdon brettlangdon merged commit ea51750 into 1.x Jan 19, 2023
@brettlangdon brettlangdon deleted the munir/debug-pytest-31-deadlocks branch January 19, 2023 14:41
@github-actions github-actions bot added this to the v1.8.0 milestone Jan 19, 2023
emmettbutler pushed a commit that referenced this pull request Jan 23, 2023
## Description

Run ddtrace test suite with pytest latest

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
emmettbutler pushed a commit that referenced this pull request Jan 30, 2023
## Description

Run ddtrace test suite with pytest latest

Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants