Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): pin httpx tests to 0.22 #4592

Closed
wants to merge 2 commits into from

Conversation

Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Nov 18, 2022

Description

This pins the httpx test suite on riot to use up to httpx<=0.22, as the most recent version 0.23.1 breaks our current patching due to removing the url.raw field.

While a fix will be implemented, in the meantime we'll skip these tests to keep CI passing.

Fixed by #4595.

Checklist

Motivation

Design

Testing strategy

Relevant issue(s)

Testing strategy

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 18, 2022
@Yun-Kim Yun-Kim requested a review from a team as a code owner November 18, 2022 17:13
@codecov-commenter
Copy link

Codecov Report

Merging #4592 (0a83e3c) into 1.x (0ea7b6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.x    #4592   +/-   ##
=======================================
  Coverage   77.95%   77.95%           
=======================================
  Files         759      759           
  Lines       60125    60125           
=======================================
  Hits        46872    46872           
  Misses      13253    13253           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2022

@Yun-Kim this pull request is now in conflict 😩

@mergify mergify bot added the conflicts label Nov 21, 2022
@brettlangdon
Copy link
Member

I don't think we need this anymore since #4595 was merged?

@Yun-Kim
Copy link
Contributor Author

Yun-Kim commented Nov 21, 2022

Closing as this workaround is no longer needed, the underlying issue was fixed by #4595

@Yun-Kim Yun-Kim closed this Nov 21, 2022
@Yun-Kim Yun-Kim deleted the yunkim/pin-httpx branch November 21, 2022 15:28
@mergify mergify bot removed the conflicts label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants