Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(mypy): remove type callable ignores (backport #4253) #4261

Closed
wants to merge 1 commit into from
Closed

ci(mypy): remove type callable ignores (backport #4253) #4261

wants to merge 1 commit into from

Commits on Oct 3, 2022

  1. Remove ignores for updated mypy (#4253) 

    Mypy==0.982 has just been released and fixed the inherent type/callable type hinting that was the problem from #4234. As a result, the type ignore comments added in #4234 to bypass the type/callable issue are not unneeded and are breaking CI.

(cherry picked from commit 0ba3e29)

# Conflicts:
#	ddtrace/profiling/collector/__init__.py
#	ddtrace/profiling/collector/memalloc.py
#	ddtrace/profiling/exporter/http.py
    @Yun-Kim @mergify
    Yun-Kim authored and mergify[bot] committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    0eb6a6a View commit details
    Browse the repository at this point in the history