Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sanic/tests): replace usage of response.stream #3887

Merged
merged 1 commit into from Jun 30, 2022
Merged

fix(sanic/tests): replace usage of response.stream #3887

merged 1 commit into from Jun 30, 2022

Conversation

Kyle-Verhoog
Copy link
Member

@Kyle-Verhoog Kyle-Verhoog commented Jun 30, 2022 •
edited by mabdinur

Description

This function was removed in sanic v22.6.0.

We can just use ResponseStream directly.

Checklist

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • PR cannot be broken up into smaller PRs.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.
  • Add to milestone.

@Kyle-Verhoog Kyle-Verhoog added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 30, 2022
@Kyle-Verhoog Kyle-Verhoog force-pushed the fix-sanic-tests branch 2 times, most recently from 95d2320 to da875e8 Compare June 30, 2022 21:17
@Kyle-Verhoog
fix(sanic/tests): replace usage of response.stream
0f7eb53 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.
@Kyle-Verhoog Kyle-Verhoog marked this pull request as ready for review June 30, 2022 21:43
@Kyle-Verhoog Kyle-Verhoog requested a review from a team as a code owner June 30, 2022 21:43
@mabdinur
Copy link
Contributor

We should backport this ci fix

@Kyle-Verhoog Kyle-Verhoog merged commit 9a2febf into DataDog:1.x Jun 30, 2022
@Kyle-Verhoog Kyle-Verhoog deleted the fix-sanic-tests branch July 1, 2022 20:34
@Kyle-Verhoog
Copy link
Member Author

@Mergifyio backport 1.2 1.1 1.0 0.x

mergify bot pushed a commit that referenced this pull request Jul 1, 2022
@Kyle-Verhoog @mergify
fix(sanic/tests): replace usage of response.stream (#3887)
fa3435a 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
@mergify mergify bot mentioned this pull request Jul 1, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 1, 2022
@Kyle-Verhoog @mergify
fix(sanic/tests): replace usage of response.stream (#3887)
a8aa94a 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
@mergify mergify bot mentioned this pull request Jul 1, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 1, 2022
@Kyle-Verhoog @mergify
fix(sanic/tests): replace usage of response.stream (#3887)
e5fbfb8 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
@mergify mergify bot mentioned this pull request Jul 1, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 1, 2022
@Kyle-Verhoog @mergify
fix(sanic/tests): replace usage of response.stream (#3887)
5c661fd 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
@mergify mergify bot mentioned this pull request Jul 1, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Jul 1, 2022

backport 1.2 1.1 1.0 0.x

✅ Backports have been created

Kyle-Verhoog added a commit that referenced this pull request Jul 1, 2022
@mergify @Kyle-Verhoog
fix(sanic/tests): replace usage of response.stream (#3887) (#3894)
eb5648c 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog added a commit that referenced this pull request Jul 1, 2022
@mergify @Kyle-Verhoog
fix(sanic/tests): replace usage of response.stream (#3887) (#3897)
7bfcfb3 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog added a commit that referenced this pull request Jul 1, 2022
@mergify @Kyle-Verhoog
fix(sanic/tests): replace usage of response.stream (#3887) (#3895)
6135434 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Kyle-Verhoog added a commit that referenced this pull request Jul 5, 2022
@mergify @Kyle-Verhoog
fix(sanic/tests): replace usage of response.stream (#3887) (#3896)
915b47e 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
@mabdinur
Copy link
Contributor

@Mergifyio backport 0.61

@mergify mergify bot mentioned this pull request Aug 16, 2022
Merged
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2022

backport 0.61

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 16, 2022
@Kyle-Verhoog @mergify
fix(sanic/tests): replace usage of response.stream (#3887)
3dd9eb4 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)
mergify bot added a commit that referenced this pull request Aug 17, 2022
@mergify @Kyle-Verhoog @mabdinur
fix(sanic/tests): replace usage of response.stream (#3887) (#4103)
e7822de 
This function was removed in sanic [v22.6.0](sanic-org/sanic#2487).

We can just use ResponseStream directly.

(cherry picked from commit 9a2febf)

Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Co-authored-by: Munir Abdinur <munir.abdinur@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZStriker19 ZStriker19 ZStriker19 approved these changes

@mabdinur mabdinur mabdinur approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kyle-Verhoog @mabdinur @ZStriker19