Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.d.ts: add child_process #4299

Closed
wants to merge 1 commit into from
Closed

Conversation

ikonst
Copy link
Contributor

@ikonst ikonst commented May 13, 2024

What does this PR do?

This seems to have been omitted in #3608.

Motivation

Being able to disable this plugin.

@ikonst ikonst requested a review from a team as a code owner May 13, 2024 23:21
@simon-id
Copy link
Member

@ikonst Hello and thank you for the contribution!
Could you please provide a little snippet of code that you were expecting to work ? So we can understand the meaning of the PR better, and to reproduce it and create a test for it.

@ikonst
Copy link
Contributor Author

ikonst commented May 14, 2024

@simon-id something like

tracer.use("child_process", { enabled: false });

@CarlesDD
Copy link
Contributor

@ikonst I've recreated your PR in #4306 to allow the CI to run. I've cherrypicked your commit so you keep authorship!

@CarlesDD
Copy link
Contributor

Released in v4.38.0 / v5.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants