Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROF-9722: Send profiler errors to the telemetry log #4278

Merged
merged 5 commits into from
May 15, 2024

Conversation

szegedi
Copy link
Contributor

@szegedi szegedi commented May 2, 2024

What does this PR do?

Sends profiler errors to the telemetry log.

Motivation

We don't have good visibility into profiler errors –– customers also won't be likely to report them, because they all happen in asynchronous paths.

Additional Notes

This PR took the stack trace sanitization code from iast-log.js and moved it into the telemetry log proper so it will be applied to all log messages regardless of who publishes them.

Copy link

github-actions bot commented May 2, 2024

Overall package size

Self size: 6.46 MB
Deduped: 59.17 MB
No deduping: 59.45 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/native-appsec 7.1.1 14.39 MB 14.4 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi force-pushed the szegedi/profiler-error-telemetry branch from 88f3d3e to 9b63a60 Compare May 3, 2024 13:27
@pr-commenter
Copy link

pr-commenter bot commented May 3, 2024

Benchmarks

Benchmark execution time: 2024-05-13 13:45:22

Comparing candidate commit 01a0936 in PR branch szegedi/profiler-error-telemetry with baseline commit 52da415 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@szegedi szegedi changed the title Send profiler errors to the telemetry log PROF-9722: Send profiler errors to the telemetry log May 6, 2024
@szegedi szegedi force-pushed the szegedi/profiler-error-telemetry branch from 7e0b60f to 01a0936 Compare May 13, 2024 12:38
@szegedi szegedi marked this pull request as ready for review May 13, 2024 13:48
@szegedi szegedi requested review from a team as code owners May 13, 2024 13:48
@szegedi szegedi requested a review from iunanua May 14, 2024 12:10
@szegedi szegedi merged commit 79f0d64 into master May 15, 2024
108 of 111 checks passed
@szegedi szegedi deleted the szegedi/profiler-error-telemetry branch May 15, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants