Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remote config support for sampling rules #4242

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ida613
Copy link
Contributor

@ida613 ida613 commented Apr 15, 2024

What does this PR do?

https://docs.google.com/document/d/12lXVniuaYenanxnpt5gJJ76a1X7gFOfmCYVQVXlHNco/edit?usp=sharing

forcing system test to run with changes in .github/workflows/system-tests.yml, will delete the change after PR passes review

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Apr 15, 2024

Overall package size

Self size: 6.59 MB
Deduped: 61.84 MB
No deduping: 62.12 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 2.1.0 14.91 MB 14.92 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.7.4 70.19 kB 739.86 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Apr 15, 2024

Benchmarks

Benchmark execution time: 2024-05-30 22:58:57

Comparing candidate commit 83a26ee in PR branch ida613/rc-sampling-rules with baseline commit 79f0d64 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 264 metrics, 2 unstable metrics.

@ida613 ida613 changed the title WIP: add remote config support support for sampling rules add remote config support support for sampling rules May 15, 2024
@ida613 ida613 marked this pull request as ready for review May 15, 2024 15:15
@ida613 ida613 requested review from a team as code owners May 15, 2024 15:15
packages/dd-trace/src/config.js Outdated Show resolved Hide resolved
packages/dd-trace/src/config.js Outdated Show resolved Hide resolved
packages/dd-trace/test/config.spec.js Show resolved Hide resolved
Co-authored-by: simon-id <simon.id@datadoghq.com>
Copy link
Member

@simon-id simon-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but wait for APM review too

simon-id
simon-id previously approved these changes May 17, 2024
@ida613 ida613 changed the title add remote config support support for sampling rules add remote config support for sampling rules May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants