Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SINT-1892] Run Datadog SCA in CI #4203

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harmonherring-pro
Copy link

What does this PR do?

Add a new Gitlab CI job that dogfoods the Datadog SCA product

Motivation

@DataDog/software-integrity-and-trust partners with @DataDog/static-analysis to dogfood their SCA product and secure Datadog's supply chain.

Additional Notes

Copy link

github-actions bot commented Mar 28, 2024

Overall package size

Self size: 6.25 MB
Deduped: 60.73 MB
No deduping: 61.01 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.7.0 16.71 MB 16.72 MB
@datadog/native-appsec 7.1.0 14.37 MB 14.38 MB
@datadog/pprof 5.2.0 8.84 MB 9.21 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.0 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.7.3 67.62 kB 731.01 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@harmonherring-pro harmonherring-pro changed the title [SINT_1892] Run Datadog SCA in CI [SINT-1892] Run Datadog SCA in CI Mar 28, 2024
@harmonherring-pro harmonherring-pro force-pushed the harmon.herring/sint-1892-deploy-sca branch from 9a6bab0 to 2761fad Compare March 28, 2024 20:37
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (71e585f) to head (6145006).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4203   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files         247      247           
  Lines       10956    10956           
  Branches       33       33           
=======================================
  Hits         9338     9338           
  Misses       1618     1618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Mar 28, 2024

Benchmarks

Benchmark execution time: 2024-03-28 20:47:54

Comparing candidate commit 6145006 in PR branch harmon.herring/sint-1892-deploy-sca with baseline commit 71e585f in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 261 metrics, 5 unstable metrics.

@harmonherring-pro harmonherring-pro marked this pull request as ready for review April 3, 2024 18:57
@harmonherring-pro harmonherring-pro requested a review from a team as a code owner April 3, 2024 18:57
Copy link
Collaborator

@juan-fernandez juan-fernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the job seems to be failing right now

Copy link

@juliendoutre juliendoutre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It seems the job fails to retrieve the Datadog API key . Did you set it correctly in SSM?

- export DD_APP_KEY=$(aws ssm get-parameter --region us-east-1 --name "ci.dd-trace-js.datadog_app_key_org2" --with-decryption --query "Parameter.Value" --out text)
- set -o xtrace
- osv-scanner --skip-git --recursive --experimental-only-packages --format=cyclonedx-1-4 --output=/tmp/sbom.json .
- datadog-ci sbom upload --service integrations-core --env ci /tmp/sbom.json

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you set the service to dd-trace-js please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants