Fix CI Visibility Gradle plugin to be compatible with Gradle build scans #6913

nikita-tkachenko-datadog · 2024-04-15T12:59:36Z

What Does This Do

Fixes the Gradle plugin injected by CI Visibility so that it does not cause Gradle build scans to fail.

Additional Notes

Attaching tracer with CI Visibility to a Gradle build that has scanning enabled causes the following error (the code is obfuscated since build scans are part of Gradle Enterprise):

Gradle version: 8.6
23562Plugin version: 3.15.1
23563
23564com.gradle.scan.plugin.internal.operations.a: Build operation dispatch of started notification failed.
23565Operation context:
23566 org.gradle.launcher.exec.RunAsBuildOperationBuildActionExecutor$1 (1): {}
23567 org.gradle.configuration.BuildOperationFiringProjectsPreparer$ConfigureBuild$1 (104): {getBuildPath=:}
23568 org.gradle.initialization.buildsrc.BuildSourceBuilder$2$1 (169): {getBuildPath=:}
23569 org.gradle.configuration.BuildOperationFiringProjectsPreparer$ConfigureBuild$1 (178): {getBuildPath=:buildSrc}
23570 org.gradle.initialization.ProjectsEvaluatedNotifier$NotifyProjectsEvaluatedListeners$1 (293): {getBuildPath=:buildSrc}
23571 org.gradle.api.internal.plugins.DefaultPluginManager$OperationDetails (294): {pluginId=null, targetPath=:, pluginClass=datadog.trace.instrumentation.gradle.CiVisibilityPlugin, targetType=project, applicationId=32, buildPath=:buildSrc}
23572Caused by: java.lang.NullPointerException: Cannot invoke "java.net.URL.getProtocol()" because "<local4>" is null
23573 at com.gradle.scan.plugin.internal.c.ae.a.a.b.a(SourceFile:62)
23574 at com.gradle.scan.plugin.internal.c.ae.a.a.e.a(SourceFile:47)
23575 at com.gradle.scan.plugin.internal.c.ae.a.b.a(SourceFile:59)
23576 at com.gradle.scan.plugin.internal.c.ae.a.b.a(SourceFile:47)
23577 at com.gradle.scan.plugin.internal.operations.b$c.started(SourceFile:140)
23578 at com.gradle.scan.plugin.internal.operations.b.a(SourceFile:55)
23579 at com.gradle.scan.plugin.internal.operations.n.a(SourceFile:33)
23580 at com.gradle.scan.plugin.internal.operations.d.a(SourceFile:60)
23581 at com.gradle.scan.plugin.internal.operations.h.a(SourceFile:39)
23582 at com.gradle.scan.plugin.internal.r.a$a.a(SourceFile:31)
23583 at com.gradle.scan.plugin.internal.r.a$a.a(SourceFile:20)
23584 at com.gradle.scan.plugin.internal.r.a.c(SourceFile:67)
23585----------

The reason the error occurs is that Gradle build scan tries to determine the location of all the plugins that the build uses, including the plugin injected by CI Visibility.
The code is roughly:

ProtectionDomain domain = pluginClass.getProtectionDomain();
CodeSource codeSource = var2.getCodeSource();
if (codeSource != null) {
    URL locationUrl = var3.getLocation();
    String protocol = locationUrl.getProtocol(); // this is where the NPE happens
    // ...
}

The CI Visibility Gradle plugin is injected by the tracer as a helper class.
Currently all the helper classes are injected with no protection domain specified.
As the result, they get assigned java.lang.ClassLoader#defaultDomain - new ProtectionDomain(new CodeSource(null, (Certificate[]) null), null, this, null): the default domain has a code source that returns null as its location, which causes the NPE above.

The proposed fix is to allow instrumentation modules to define the protection domain that will be assigned to the injected classes.

The protection domain for the Gradle plugin module has code source that points to the tracer JAR and class loader that is the CL where the plugin is injected.

Jira ticket: SCV-157

pr-commenter · 2024-04-15T13:47:14Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	nikita-tkachenko/fix-ci-vis-gradle-build-scans
git_commit_date	1714584487	1714599911
git_commit_sha	`5c8d55c`	`c007c15`
release_version	1.34.0-SNAPSHOT~5c8d55ca87	1.33.0-SNAPSHOT~c007c15acc

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714603435	1714603435
ci_job_id	502150007	502150007
ci_pipeline_id	33387373	33387373
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 15 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.33.0-SNAPSHOT~c007c15acc, baseline=1.34.0-SNAPSHOT~5c8d55ca87

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1083770
Total [baseline] (10.475 s) : 0, 10475255
Agent [candidate] (1.083 s) : 0, 1082945
Total [candidate] (10.372 s) : 0, 10372118
section appsec
Agent [baseline] (1.209 s) : 0, 1209067
Total [baseline] (10.524 s) : 0, 10523880
Agent [candidate] (1.201 s) : 0, 1201129
Total [candidate] (10.524 s) : 0, 10524361
section iast
Agent [baseline] (1.208 s) : 0, 1208376
Total [baseline] (10.757 s) : 0, 10757002
Agent [candidate] (1.202 s) : 0, 1202054
Total [candidate] (10.79 s) : 0, 10790069
section profiling
Agent [baseline] (1.293 s) : 0, 1292803
Total [baseline] (10.694 s) : 0, 10694136
Agent [candidate] (1.273 s) : 0, 1273064
Total [candidate] (10.64 s) : 0, 10639863

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.084 s	-
Agent	appsec	1.209 s	125.297 ms (11.6%)
Agent	iast	1.208 s	124.606 ms (11.5%)
Agent	profiling	1.293 s	209.033 ms (19.3%)
Total	tracing	10.475 s	-
Total	appsec	10.524 s	48.625 ms (0.5%)
Total	iast	10.757 s	281.746 ms (2.7%)
Total	profiling	10.694 s	218.881 ms (2.1%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.083 s	-
Agent	appsec	1.201 s	118.183 ms (10.9%)
Agent	iast	1.202 s	119.109 ms (11.0%)
Agent	profiling	1.273 s	190.118 ms (17.6%)
Total	tracing	10.372 s	-
Total	appsec	10.524 s	152.243 ms (1.5%)
Total	iast	10.79 s	417.952 ms (4.0%)
Total	profiling	10.64 s	267.746 ms (2.6%)

gantt
    title petclinic - break down per module: candidate=1.33.0-SNAPSHOT~c007c15acc, baseline=1.34.0-SNAPSHOT~5c8d55ca87

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (679.893 ms) : 0, 679893
BytebuddyAgent [candidate] (678.064 ms) : 0, 678064
GlobalTracer [baseline] (311.533 ms) : 0, 311533
GlobalTracer [candidate] (312.209 ms) : 0, 312209
AppSec [baseline] (49.437 ms) : 0, 49437
AppSec [candidate] (49.737 ms) : 0, 49737
Remote Config [baseline] (661.63 µs) : 0, 662
Remote Config [candidate] (664.596 µs) : 0, 665
Telemetry [baseline] (7.599 ms) : 0, 7599
Telemetry [candidate] (7.618 ms) : 0, 7618
section appsec
BytebuddyAgent [baseline] (700.455 ms) : 0, 700455
BytebuddyAgent [candidate] (697.502 ms) : 0, 697502
GlobalTracer [baseline] (293.58 ms) : 0, 293580
GlobalTracer [candidate] (292.897 ms) : 0, 292897
AppSec [baseline] (149.858 ms) : 0, 149858
AppSec [candidate] (149.939 ms) : 0, 149939
IAST [baseline] (19.41 ms) : 0, 19410
IAST [candidate] (18.935 ms) : 0, 18935
Remote Config [baseline] (612.009 µs) : 0, 612
Remote Config [candidate] (608.424 µs) : 0, 608
Telemetry [baseline] (10.599 ms) : 0, 10599
Telemetry [candidate] (6.832 ms) : 0, 6832
section iast
BytebuddyAgent [baseline] (801.573 ms) : 0, 801573
BytebuddyAgent [candidate] (795.815 ms) : 0, 795815
GlobalTracer [baseline] (290.06 ms) : 0, 290060
GlobalTracer [candidate] (289.533 ms) : 0, 289533
AppSec [baseline] (50.973 ms) : 0, 50973
AppSec [candidate] (48.355 ms) : 0, 48355
IAST [baseline] (23.356 ms) : 0, 23356
IAST [candidate] (24.528 ms) : 0, 24528
Remote Config [baseline] (569.05 µs) : 0, 569
Remote Config [candidate] (572.266 µs) : 0, 572
Telemetry [baseline] (7.397 ms) : 0, 7397
Telemetry [candidate] (8.916 ms) : 0, 8916
section profiling
BytebuddyAgent [baseline] (690.205 ms) : 0, 690205
BytebuddyAgent [candidate] (679.814 ms) : 0, 679814
GlobalTracer [baseline] (387.823 ms) : 0, 387823
GlobalTracer [candidate] (382.775 ms) : 0, 382775
AppSec [baseline] (51.249 ms) : 0, 51249
AppSec [candidate] (50.291 ms) : 0, 50291
Remote Config [baseline] (728.708 µs) : 0, 729
Remote Config [candidate] (704.335 µs) : 0, 704
Telemetry [baseline] (7.68 ms) : 0, 7680
Telemetry [candidate] (7.473 ms) : 0, 7473
ProfilingAgent [baseline] (97.767 ms) : 0, 97767
ProfilingAgent [candidate] (95.651 ms) : 0, 95651
Profiling [baseline] (97.791 ms) : 0, 97791
Profiling [candidate] (95.675 ms) : 0, 95675

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.33.0-SNAPSHOT~c007c15acc, baseline=1.34.0-SNAPSHOT~5c8d55ca87

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.077 s) : 0, 1076769
Total [baseline] (8.541 s) : 0, 8541307
Agent [candidate] (1.089 s) : 0, 1088590
Total [candidate] (8.608 s) : 0, 8607651
section iast
Agent [baseline] (1.21 s) : 0, 1209926
Total [baseline] (9.032 s) : 0, 9032061
Agent [candidate] (1.208 s) : 0, 1208105
Total [candidate] (9.027 s) : 0, 9026507
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203711
Total [baseline] (8.988 s) : 0, 8988313
Agent [candidate] (1.199 s) : 0, 1199245
Total [candidate] (8.999 s) : 0, 8998931
section iast_TELEMETRY_OFF
Agent [baseline] (1.213 s) : 0, 1213488
Total [baseline] (9.017 s) : 0, 9017362
Agent [candidate] (1.205 s) : 0, 1204857
Total [candidate] (9.014 s) : 0, 9014467

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.077 s	-
Agent	iast	1.21 s	133.157 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.204 s	126.943 ms (11.8%)
Agent	iast_TELEMETRY_OFF	1.213 s	136.719 ms (12.7%)
Total	tracing	8.541 s	-
Total	iast	9.032 s	490.754 ms (5.7%)
Total	iast_HARDCODED_SECRET_DISABLED	8.988 s	447.006 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.017 s	476.055 ms (5.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.089 s	-
Agent	iast	1.208 s	119.515 ms (11.0%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.199 s	110.655 ms (10.2%)
Agent	iast_TELEMETRY_OFF	1.205 s	116.268 ms (10.7%)
Total	tracing	8.608 s	-
Total	iast	9.027 s	418.857 ms (4.9%)
Total	iast_HARDCODED_SECRET_DISABLED	8.999 s	391.28 ms (4.5%)
Total	iast_TELEMETRY_OFF	9.014 s	406.816 ms (4.7%)

gantt
    title insecure-bank - break down per module: candidate=1.33.0-SNAPSHOT~c007c15acc, baseline=1.34.0-SNAPSHOT~5c8d55ca87

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.617 ms) : 0, 674617
BytebuddyAgent [candidate] (681.824 ms) : 0, 681824
GlobalTracer [baseline] (310.22 ms) : 0, 310220
GlobalTracer [candidate] (313.627 ms) : 0, 313627
AppSec [baseline] (49.372 ms) : 0, 49372
AppSec [candidate] (50.186 ms) : 0, 50186
Remote Config [baseline] (654.336 µs) : 0, 654
Remote Config [candidate] (678.966 µs) : 0, 679
Telemetry [baseline] (7.497 ms) : 0, 7497
Telemetry [candidate] (7.652 ms) : 0, 7652
section iast
BytebuddyAgent [baseline] (801.67 ms) : 0, 801670
BytebuddyAgent [candidate] (800.246 ms) : 0, 800246
GlobalTracer [baseline] (290.591 ms) : 0, 290591
GlobalTracer [candidate] (290.667 ms) : 0, 290667
AppSec [baseline] (50.444 ms) : 0, 50444
AppSec [candidate] (50.108 ms) : 0, 50108
IAST [baseline] (25.206 ms) : 0, 25206
IAST [candidate] (24.506 ms) : 0, 24506
Remote Config [baseline] (638.905 µs) : 0, 639
Remote Config [candidate] (580.489 µs) : 0, 580
Telemetry [baseline] (6.701 ms) : 0, 6701
Telemetry [candidate] (7.384 ms) : 0, 7384
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (798.093 ms) : 0, 798093
BytebuddyAgent [candidate] (794.344 ms) : 0, 794344
GlobalTracer [baseline] (288.348 ms) : 0, 288348
GlobalTracer [candidate] (288.808 ms) : 0, 288808
AppSec [baseline] (52.28 ms) : 0, 52280
AppSec [candidate] (50.155 ms) : 0, 50155
IAST [baseline] (22.519 ms) : 0, 22519
IAST [candidate] (23.611 ms) : 0, 23611
Remote Config [baseline] (1.32 ms) : 0, 1320
Remote Config [candidate] (577.004 µs) : 0, 577
Telemetry [baseline] (6.645 ms) : 0, 6645
Telemetry [candidate] (7.361 ms) : 0, 7361
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (804.382 ms) : 0, 804382
BytebuddyAgent [candidate] (798.455 ms) : 0, 798455
GlobalTracer [baseline] (292.06 ms) : 0, 292060
GlobalTracer [candidate] (290.551 ms) : 0, 290551
AppSec [baseline] (50.249 ms) : 0, 50249
AppSec [candidate] (51.151 ms) : 0, 51151
IAST [baseline] (23.379 ms) : 0, 23379
IAST [candidate] (22.974 ms) : 0, 22974
Remote Config [baseline] (585.154 µs) : 0, 585
Remote Config [candidate] (571.827 µs) : 0, 572
Telemetry [baseline] (8.054 ms) : 0, 8054
Telemetry [candidate] (6.554 ms) : 0, 6554

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-05-01T22:16:10	2024-05-01T22:38:10
git_branch	master	nikita-tkachenko/fix-ci-vis-gradle-build-scans
git_commit_date	1714584487	1714599911
git_commit_sha	`5c8d55c`	`c007c15`
release_version	1.34.0-SNAPSHOT~5c8d55ca87	1.33.0-SNAPSHOT~c007c15acc
start_time	2024-05-01T22:15:57	2024-05-01T22:37:56

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1714603435	1714603435
ci_job_id	502150007	502150007
ci_pipeline_id	33387373	33387373
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.33.0-SNAPSHOT~c007c15acc, baseline=1.34.0-SNAPSHOT~5c8d55ca87
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1368
.   : milestone, 1347,
appsec (1.731 ms) : 1707, 1756
.   : milestone, 1731,
appsec_no_iast (1.749 ms) : 1725, 1773
.   : milestone, 1749,
iast (1.499 ms) : 1477, 1521
.   : milestone, 1499,
profiling (1.517 ms) : 1492, 1542
.   : milestone, 1517,
tracing (1.476 ms) : 1451, 1500
.   : milestone, 1476,
section candidate
no_agent (1.367 ms) : 1347, 1386
.   : milestone, 1367,
appsec (1.712 ms) : 1687, 1737
.   : milestone, 1712,
appsec_no_iast (1.724 ms) : 1699, 1748
.   : milestone, 1724,
iast (1.495 ms) : 1472, 1519
.   : milestone, 1495,
profiling (1.487 ms) : 1462, 1512
.   : milestone, 1487,
tracing (1.493 ms) : 1469, 1517
.   : milestone, 1493,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.347 ms [1.327 ms, 1.368 ms]	-
appsec	1.731 ms [1.707 ms, 1.756 ms]	384.164 µs (28.5%)
appsec_no_iast	1.749 ms [1.725 ms, 1.773 ms]	401.996 µs (29.8%)
iast	1.499 ms [1.477 ms, 1.521 ms]	151.69 µs (11.3%)
profiling	1.517 ms [1.492 ms, 1.542 ms]	169.97 µs (12.6%)
tracing	1.476 ms [1.451 ms, 1.5 ms]	128.557 µs (9.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.367 ms [1.347 ms, 1.386 ms]	-
appsec	1.712 ms [1.687 ms, 1.737 ms]	345.258 µs (25.3%)
appsec_no_iast	1.724 ms [1.699 ms, 1.748 ms]	356.742 µs (26.1%)
iast	1.495 ms [1.472 ms, 1.519 ms]	128.469 µs (9.4%)
profiling	1.487 ms [1.462 ms, 1.512 ms]	120.108 µs (8.8%)
tracing	1.493 ms [1.469 ms, 1.517 ms]	126.493 µs (9.3%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.33.0-SNAPSHOT~c007c15acc, baseline=1.34.0-SNAPSHOT~5c8d55ca87
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.255 µs) : 357, 397
.   : milestone, 377,
iast (479.736 µs) : 458, 502
.   : milestone, 480,
iast_FULL (541.793 µs) : 520, 563
.   : milestone, 542,
iast_GLOBAL (501.026 µs) : 480, 522
.   : milestone, 501,
iast_HARDCODED_SECRET_DISABLED (481.131 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (450.298 µs) : 429, 471
.   : milestone, 450,
iast_TELEMETRY_OFF (466.572 µs) : 446, 487
.   : milestone, 467,
tracing (446.112 µs) : 425, 467
.   : milestone, 446,
section candidate
no_agent (366.041 µs) : 346, 386
.   : milestone, 366,
iast (478.398 µs) : 457, 500
.   : milestone, 478,
iast_FULL (546.341 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (508.47 µs) : 486, 531
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (479.701 µs) : 459, 501
.   : milestone, 480,
iast_INACTIVE (444.604 µs) : 424, 465
.   : milestone, 445,
iast_TELEMETRY_OFF (471.998 µs) : 452, 492
.   : milestone, 472,
tracing (443.563 µs) : 423, 464
.   : milestone, 444,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.255 µs [357.315 µs, 397.194 µs]	-
iast	479.736 µs [457.926 µs, 501.545 µs]	102.481 µs (27.2%)
iast_FULL	541.793 µs [520.423 µs, 563.162 µs]	164.538 µs (43.6%)
iast_GLOBAL	501.026 µs [480.123 µs, 521.928 µs]	123.771 µs (32.8%)
iast_HARDCODED_SECRET_DISABLED	481.131 µs [459.975 µs, 502.286 µs]	103.876 µs (27.5%)
iast_INACTIVE	450.298 µs [429.496 µs, 471.099 µs]	73.043 µs (19.4%)
iast_TELEMETRY_OFF	466.572 µs [445.876 µs, 487.268 µs]	89.318 µs (23.7%)
tracing	446.112 µs [425.387 µs, 466.837 µs]	68.858 µs (18.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	366.041 µs [346.261 µs, 385.82 µs]	-
iast	478.398 µs [457.106 µs, 499.689 µs]	112.357 µs (30.7%)
iast_FULL	546.341 µs [525.441 µs, 567.24 µs]	180.3 µs (49.3%)
iast_GLOBAL	508.47 µs [485.754 µs, 531.185 µs]	142.429 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED	479.701 µs [458.611 µs, 500.792 µs]	113.661 µs (31.1%)
iast_INACTIVE	444.604 µs [424.184 µs, 465.024 µs]	78.563 µs (21.5%)
iast_TELEMETRY_OFF	471.998 µs [451.587 µs, 492.409 µs]	105.957 µs (28.9%)
tracing	443.563 µs [423.159 µs, 463.968 µs]	77.522 µs (21.2%)

Dacapo

PerfectSlayer · 2024-04-22T12:20:23Z

I would like a review from @mcculls for this PR.

mcculls

Have we submitted a report upstream to fix build scan? It looks like a bug in build scan to assume locationUrl is non-null

In terms of this PR I think we can simplify it a lot, we don't need the feature to supply arbitrary code-sources - we just need a flag to tell it to use the agent's code-source.

So I'd suggest removing the factory and have HelperInjector pick the domain based on the instrumentation's value of that flag.

nikita-tkachenko-datadog · 2024-04-30T10:42:16Z

Have we submitted a report upstream to fix build scan? It looks like a bug in build scan to assume locationUrl is non-null

In terms of this PR I think we can simplify it a lot, we don't need the feature to supply arbitrary code-sources - we just need a flag to tell it to use the agent's code-source.

So I'd suggest removing the factory and have HelperInjector pick the domain based on the instrumentation's value of that flag.

Issue submitted.
I also reworked this PR to use the boolean flag instead of factory, as you suggested.

...ent/agent-builder/src/main/java/datadog/trace/agent/tooling/CombiningTransformerBuilder.java

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/HelperInjector.java

mcculls

+1, thanks

just some minor suggestions

nikita-tkachenko-datadog added type: bug comp: ci visibility Continuous Integration Visibility labels Apr 15, 2024

nikita-tkachenko-datadog marked this pull request as ready for review April 15, 2024 20:20

nikita-tkachenko-datadog requested review from a team as code owners April 15, 2024 20:20

nikita-tkachenko-datadog requested review from romainkomorndatadog, PerfectSlayer and ygree April 15, 2024 20:20

romainkomorndatadog approved these changes Apr 16, 2024

View reviewed changes

PerfectSlayer requested a review from mcculls April 22, 2024 12:20

mcculls requested changes Apr 29, 2024

View reviewed changes

Fix CI Visibility Gradle plugin to be compatible with Gradle build scans

a9aaae3

nikita-tkachenko-datadog force-pushed the nikita-tkachenko/fix-ci-vis-gradle-build-scans branch from d91d840 to a9aaae3 Compare April 30, 2024 10:38

nikita-tkachenko-datadog requested a review from mcculls April 30, 2024 11:57

mcculls reviewed May 1, 2024

View reviewed changes

...ent/agent-builder/src/main/java/datadog/trace/agent/tooling/CombiningTransformerBuilder.java Outdated Show resolved Hide resolved

mcculls reviewed May 1, 2024

View reviewed changes

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/HelperInjector.java Outdated Show resolved Hide resolved

mcculls approved these changes May 1, 2024

View reviewed changes

Address review comments

c007c15

nikita-tkachenko-datadog merged commit eb1a1e3 into master May 3, 2024
77 checks passed

nikita-tkachenko-datadog deleted the nikita-tkachenko/fix-ci-vis-gradle-build-scans branch May 3, 2024 08:34

github-actions bot added this to the 1.34.0 milestone May 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CI Visibility Gradle plugin to be compatible with Gradle build scans #6913

Fix CI Visibility Gradle plugin to be compatible with Gradle build scans #6913

nikita-tkachenko-datadog commented Apr 15, 2024 •

edited by jira bot

pr-commenter bot commented Apr 15, 2024 •

edited

PerfectSlayer commented Apr 22, 2024

mcculls left a comment

nikita-tkachenko-datadog commented Apr 30, 2024

mcculls left a comment

Fix CI Visibility Gradle plugin to be compatible with Gradle build scans #6913

Fix CI Visibility Gradle plugin to be compatible with Gradle build scans #6913

Conversation

nikita-tkachenko-datadog commented Apr 15, 2024 • edited by jira bot

What Does This Do

Additional Notes

pr-commenter bot commented Apr 15, 2024 • edited

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

PerfectSlayer commented Apr 22, 2024

mcculls left a comment

Choose a reason for hiding this comment

nikita-tkachenko-datadog commented Apr 30, 2024

mcculls left a comment

Choose a reason for hiding this comment

nikita-tkachenko-datadog commented Apr 15, 2024 •

edited by jira bot

pr-commenter bot commented Apr 15, 2024 •

edited