Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: remove agent_psr when rule_psr is set #2668

Merged

Conversation

dianashevchenko
Copy link
Contributor

@dianashevchenko dianashevchenko commented Apr 22, 2024

What does this PR do?

APMAPI-22
Removes the '_dd.agent_psr' metric when '_dd.rule_psr' is set through sampling rules.

Motivation

The backend currently handles this because there is a precedence rule, but it should be fixed. Impact is sampling “reason” shown to the user in the frontend can be misleading/wrong

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@dianashevchenko dianashevchenko requested a review from a team as a code owner April 22, 2024 15:06
Base automatically changed from shevchenko/manual-keep-bug to main April 22, 2024 15:10
@pr-commenter
Copy link

pr-commenter bot commented Apr 22, 2024

Benchmarks

Benchmark execution time: 2024-04-30 12:59:26

Comparing candidate commit 6fa2b0a in PR branch shevchenko/remove-agent_psr-when-rule-sampling with baseline commit 155ef2d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

Copy link
Contributor

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dianashevchenko dianashevchenko enabled auto-merge (squash) April 30, 2024 12:37
@dianashevchenko dianashevchenko requested a review from a team as a code owner May 8, 2024 14:17
@dianashevchenko dianashevchenko merged commit 93ee25e into main May 8, 2024
157 of 158 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/remove-agent_psr-when-rule-sampling branch May 8, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants