Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/v2check: implement migration tool with all the required changes #2656

Open
wants to merge 13 commits into
base: v2-dev
Choose a base branch
from

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Apr 10, 2024

What does this PR do?

Adds known required changes to migrate an instrumented v1 codebase to v2.

Motivation

Complete v2 release and migration.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Apr 10, 2024

Benchmarks

Benchmark execution time: 2024-04-22 09:33:40

Comparing candidate commit b084466 in PR branch dario.castane/AIT-8750/migration-tool-v2 with baseline commit 75c8781 in branch v2-dev.

Found 1 performance improvements and 2 performance regressions! Performance is the same for 37 metrics, 1 unstable metrics.

scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-24

  • 🟩 execution_time [-183.028ns; -115.172ns] or [-3.479%; -2.189%]

scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24

  • 🟥 execution_time [+5.935µs; +7.907µs] or [+2.338%; +3.115%]

scenario:BenchmarkStartRequestSpan-24

  • 🟥 execution_time [+7.235ns; +8.145ns] or [+2.027%; +2.282%]

@darccio darccio marked this pull request as ready for review May 10, 2024 14:29
@darccio darccio requested a review from a team as a code owner May 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant