New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: support default origin on dynamic config to support Active Tracing telemetry spec #2623
Open
darccio
wants to merge
5
commits into
main
Choose a base branch
from
dario.castane/AIT-9990-default-origin
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ddtrace/tracer: support default origin on dynamic config to support Active Tracing telemetry spec #2623
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c65f534
ddtrace/tracer: support default origin on dynamic config to support A…
darccio 40be10c
Merge branch 'main' into dario.castane/AIT-9990-default-origin
darccio 430d876
.github/workflows: use specific branch to test new parametric tests
darccio 46bb463
ddtrace/tracer: set trace_sample_rate origin to env_var if present
darccio a08e194
Merge branch 'main' into dario.castane/AIT-9990-default-origin
darccio File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just made me wonder whether the other settings that are available through RC should also get
origin: originEnvVar
on their dynamicConfig when enabled via env var, e.g,DD_TRACE_ENABLED
Maybe newDynamicConfig() should accept a value for origin, or maybe these we should also call
dynamicConfig.update(val, originEnvVar)
for these other optionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtoffl01 You are right. I left this one as example and reminder to add more in a separate PR. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this. Ideally the constructor should set the origin.
If for some reason we can't use the constructor to do so, the generic
dynamicConfig
type should provide a method to update the startup and current values and their origins instead of manipulating the fields directly inddtrace/tracer/option.go
.