[Draft; don't merge] v1 as frontend of v2 #2607
Draft
+2,787
−65,344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounterparts Some functions have been adapted if v2 changed the API. Type aliases are the preferred way to convert types unless introducing an alias may leak v2 details. We kept some types as they would expose v2 types, using manual conversion for these in the frontend functions that require them. We kept as much tests as possible, but some were removed because they were asserting internal working no longer accessible, as v1 is an external user of v2.
…ir v2 counterparts The original API is kept as is, wrapping around v2 equivalent code and configs, maintaining the behaviour expected by the package's tests.
…terparts The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions.
…parts The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions, including the types as v2 aliases.
The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions.
…2 counterparts The conversion turned the API to a pure transparent frontend, with exported functions calling their v2 versions. Option types have been aliased, and contrib types have been used as wrappers to embed their v2 versions.
…ion for tests expecting v1's mocktracer.Span
…lue instead of a pointer in GetGlobalTracer
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BenchmarksBenchmark execution time: 2024-03-20 12:43:36 Comparing candidate commit 390dd0b in PR branch Found 24 performance improvements and 7 performance regressions! Performance is the same for 10 metrics, 0 unstable metrics. scenario:BenchmarkHttpServeTrace-24
scenario:BenchmarkOTelApiWithCustomTags/datadog_otel_api-24
scenario:BenchmarkOTelApiWithCustomTags/otel_api-24
scenario:BenchmarkPartialFlushing/Disabled-24
scenario:BenchmarkPartialFlushing/Enabled-24
scenario:BenchmarkSingleSpanRetention/no-rules-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-all-24
scenario:BenchmarkSingleSpanRetention/with-rules/match-half-24
scenario:BenchmarkStartRequestSpan-24
scenario:BenchmarkStartSpan-24
scenario:BenchmarkTracerAddSpans-24
|
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Turns the current v1 a frontend of v2, wrapping the new API while keeping the original behaviour.
Motivation
Simplify internal testing and future migration to v2.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!