[contrib/gocql] reporting both cluster and datacenter #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
BenchmarksBenchmark execution time: 2024-02-26 17:01:49 Comparing candidate commit b4e7557 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
rarguelloF
reviewed
Feb 26, 2024
| @@ -242,7 +242,8 @@ func (tq *Query) Iter() *Iter { | |||
| if tIter.Host() != nil { | |||
| tIter.span.SetTag(ext.TargetHost, tIter.Iter.Host().HostID()) | |||
| tIter.span.SetTag(ext.TargetPort, strconv.Itoa(tIter.Iter.Host().Port())) | |||
| tIter.span.SetTag(ext.CassandraCluster, tIter.Iter.Host().DataCenter()) | |||
There was a problem hiding this comment.
We should be careful before merging this, as it can be a breaking change for anyone relying on the value of this tag.
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been open for 30 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Report both cluster and datacenter.
Quoting this Datastax doc
An Apache Cassandra Datacenter is a group of nodes, related and configured within a cluster for replication purposes.Also as a side quest it updates the CI image to 3.11 which:
Motivation
Report more insightful metadata.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!