contrib/database/sql: Submit DBStats as Datadog metrics #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ib, and expose tracer statsd client
github-actions
bot
added
the
apm:ecosystem
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
BenchmarksBenchmark execution time: 2024-02-27 18:57:47 Comparing candidate commit 9523300 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 1 unstable metrics. scenario:BenchmarkPartialFlushing/Disabled-24
|
…nd tracer to share stats from former to latter
Co-authored-by: Katie Hockman <katie@hockman.dev>
8 tasks
…en passed to Register
katiehockman
approved these changes
Feb 26, 2024
…to mtoff/sql_metrics
felixge
reviewed
Mar 2, 2024
| MaxIdleClosed = tracerPrefix + "sql.db.connections.closed.max_idle_conns" | ||
| MaxIdleTimeClosed = tracerPrefix + "sql.db.connections.closed.max_idle_time" | ||
| MaxLifetimeClosed = tracerPrefix + "sql.db.connections.closed.max_lifetime" | ||
| ) |
There was a problem hiding this comment.
NIT: Should these be public? (if not, we could still make them private before the next release starts on Monday, cc @dianashevchenko )
There was a problem hiding this comment.
No, there's no need for these to be public, that was just an oversight!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Publicly, this PR exposes a contrib/database/sql option to enable polling and submission of DBStats as metrics to Datadog
Ref: https://pkg.go.dev/database/sql#DBStats
This PR also lays the groundwork on the
tracerpackage for submitting statsd payloads from other contrib integrations in the future, if desiredMotivation
Customer requests
#2303
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!