Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft; don't merge] v2.0.0-alpha #2427

Draft
wants to merge 512 commits into
base: main
Choose a base branch
from
Draft

[Draft; don't merge] v2.0.0-alpha #2427

wants to merge 512 commits into from
+26,871 −16,884

Conversation

darccio
Copy link
Contributor

@darccio darccio commented Dec 12, 2023

What does this PR do?

This PR is a preview of the changes that will be merged into main for v2 release as github.com/DataDog/dd-trace-go/v2.

Motivation

These are the main motivations behind releasing a v2:

  • Migrate from gopkg.in: this causes pain in enterprise customers.
  • Long due refactor: moving away from interfaces in favor of concrete types in the API is a requirement to avoid situations where we had to hack a solution because adding functions caused breaking changes.
  • Mitigate false-positive results from third party security scanners: due to our bloated go.mod pulling contrib’s dependencies. Also, remove deprecated dependencies’ contribs.
  • Reduce library misuse: introduce better patterns, like using context to start spans to ensure trace propagation.
  • Long backlog of proposals blocked waiting for a never-getting-planned v2.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

github-actions[bot]
github-actions bot reviewed Dec 12, 2023
View reviewed changes
ddtrace/example_test.go Outdated Show resolved Hide resolved
ddtrace/opentelemetry/span.go Outdated Show resolved Hide resolved
ddtrace/opentelemetry/tracer_test.go Outdated Show resolved Hide resolved
internal/appsec/waf_test.go Outdated Show resolved Hide resolved
internal/appsec/emitter/httpsec/http.go Show resolved Hide resolved
internal/appsec/trace/grpctrace/grpc.go Show resolved Hide resolved
internal/contrib/httptrace/httptrace.go Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Dec 12, 2023
View reviewed changes
internal/appsec/listener/grpcsec/grpc.go Show resolved Hide resolved
internal/appsec/waf.go Outdated Show resolved Hide resolved
@darccio
internal/*: upgrade dd-trace-go
98f86ca
@darccio
v2/contrib/*: upgrade dd-trace-go
26fd25e
@darccio
.github/workflows: simplify unit-integration-tests.yml removing setup…
b48995f 
…-go before reviewdog/action-golangci-lint
@darccio
internal/appsec: go fmt
c0242a0
@darccio
Merge branch 'main' into v2-dev
8932921
@darccio
.github/workflows/apps: add logging
ed87b9a
@darccio
v2/contrib/gorilla/mux: go mod tidy
c12a98e
@darccio
v2/contrib/google.golang.org/api: go mod tidy
03aabbd
@darccio
v2/contrib/*: fix inconsistent go.mods
96a7fb3
@darccio
go.mod: align go.mod with main
f0d2937
@darccio
v2: stabilize contribs go.mod
1c62b2f
@darccio
v2/contrib/google.golang.org/api/internal/gen_endpoints: fix go.sum
34ae239
@darccio
Merge remote-tracking branch 'origin/main' into v2-dev
004877c
@darccio
.github/workflows: add contribs smoke tests
7da8714
@darccio
.github/workflows: install gotestsum for contribs' smoke tests
64b5f4b
@darccio
.github/workflows: add support for test results path
6acbdcf
@darccio
.github/workflows/apps: add -t to contribs' go get for smoke tests
0ad0231
@darccio
.github/workflows: add -t to smoke tests go get to include test packages
c592d67
@darccio
Merge remote-tracking branch 'origin/main' into v2-dev
e424dbf
@darccio
v2/contrib/aws/*: add empty go files to allow govulncheck to work
93bb147
@darccio
.github/workflows: add ref to waf-disabled checkout
a480295
@darccio
.github/workflows: adapt govunlcheck workflow to some special cases i…
89d3f4f 
…n contribs
@darccio
.github/workflows: add logging to govulncheck step
740580a
@darccio
.github/workflows: fix bash conditional
b3096c2
@darccio
.github/workflows: skip aws-sdk-go contribs
41483cb
@darccio
.github/workflows: move govulncheck for contribs to a bash script
c0f9915
@darccio
.github/workflows: add execution permission to govulncheck-contribs-v…
31f2051 
…2.sh
@darccio
Merge remote-tracking branch 'origin/main' into v2-dev
6bb06a7
darccio and others added 17 commits March 20, 2024 14:04
@darccio
internal/contrib/httptrace: improve memory management in StartRequest…
1559d0b 
…Span
@darccio
v2/contrib/confluentinc/confluent-kafka-go/kafka*: skip nil options
7ebff8f
@mabdinur
chore(otel): adds an API for generating span links (#2614)
224a0bc
@darccio
.github/workflows: fix v2-dev nightly tests
918fafc
@darccio
internal/contrib/options: fix import cycle
3ad51a7
@darccio
Merge remote-tracking branch 'origin' into v2-dev
5b596d3
@darccio
ddtrace/tracer: fix tests
1694bdb
@darccio
v2/contrib/google.golang.org/grpc: fix tests
c4cfc74
@darccio
Merge remote-tracking branch 'origin/main' into v2-dev
29a213f
@darccio
ddtrace/tracer: create JSON rule in {Span,Trace}SamplingRules
7fc215e
@darccio
.github/workflows: don't exit on test failure
55cf688
@darccio
.github/workflows: don't pass a value to run smoke tests in v2
09c1b4f
@darccio
internal/apps/setup-smoke-test: use go work vendor instead of go mod …
8af9f77 
…vendor
@darccio
internal/apps/setup-smoke-test: revert using go work vendor instead o…
9562112 
…f go mod vendor
@darccio
internal/apps/setup-smoke-test: use go work vendor ONLY IN 1.22 inste…
e062db3 
…ad of go mod vendor
@darccio
internal/apps/setup-smoke-test: add $go argument in corresponding bui…
6f9f98f 
…ld stage
@darccio
.github/workflows: disable reviewdog
42807ee
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label May 1, 2024
@darccio darccio removed the stale Stuck for more than 1 month label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@darccio @knusbaum @ahmed-mez @dianashevchenko @katiehockman @mabdinur