Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: fix span start option races #2418

Merged
merged 23 commits into from
Dec 12, 2023
Merged

contrib: fix span start option races #2418

merged 23 commits into from
Dec 12, 2023

Commits on Dec 7, 2023

  1. contrib/*: fix multiple spanOpts potential append() data race 

    Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
    @eliottness
    eliottness committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8f24d7b View commit details
    Browse the repository at this point in the history

  2. fix start span option races

    Julio Guerra committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    2ef8ddc View commit details
    Browse the repository at this point in the history

  3. fix echo span tag ordering

    Julio Guerra committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    5e8ff05 View commit details
    Browse the repository at this point in the history

  4. fix chi options

    Julio Guerra committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    1b1eba1 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. refactor to make copies more explicit and add helper method

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    260f6d8 View commit details
    Browse the repository at this point in the history

  2. move OptionsCopy to a new contrib-wide internal package

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9778ffe View commit details
    Browse the repository at this point in the history

  3. add a unit test for OptionsCopy

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    f24ebd3 View commit details
    Browse the repository at this point in the history

  4. rename options.OptionsCopy to options.Copy to avoid repetitive naming

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    694bf1f View commit details
    Browse the repository at this point in the history

  5. fix additional races in other packages

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4fe86a7 View commit details
    Browse the repository at this point in the history

  6. gofmt on roundtripper.go

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    346aa7c View commit details
    Browse the repository at this point in the history

  7. clarify godoc for options.Copy

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    64fd168 View commit details
    Browse the repository at this point in the history

  8. small cleanups to avoid unnecessary changes

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    5bc5a22 View commit details
    Browse the repository at this point in the history

  9. revert changes to fiber.go and roundtripper.go

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    bcb9b19 View commit details
    Browse the repository at this point in the history

  10. avoid opts change side effects in goji.go and httptreemux.go

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    ddf67cd View commit details
    Browse the repository at this point in the history

  11. fix httptreemux.go based on https://go.dev/play/p/bcPus1ofHPd

    @katiehockman
    katiehockman committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7b0ae77 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. remove all changes that aren't strictly necessary to fix the race

    @katiehockman
    katiehockman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    0b9c2db View commit details
    Browse the repository at this point in the history

  2. remove unecessary changes in httptreemux.go

    @katiehockman
    katiehockman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    bb7a30d View commit details
    Browse the repository at this point in the history

  3. fix TraceAndServe in contrib/net/http

    @katiehockman
    katiehockman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    4b0e472 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into eliott.bouhana/fix-span-opts-race

    @katiehockman
    katiehockman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    492981b View commit details
    Browse the repository at this point in the history

  5. allocate enough space in the destination slice to make the fully copy

    @katiehockman
    katiehockman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    01dd225 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'eliott.bouhana/fix-span-opts-race' of github.com:DataDo… 

    …g/dd-trace-go into eliott.bouhana/fix-span-opts-race
    @katiehockman
    katiehockman committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    1ab2a4c View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. remove unnecessary changes in goji.go

    @katiehockman
    katiehockman committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3c089f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into eliott.bouhana/fix-span-opts-race

    @katiehockman
    katiehockman committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    d9b7e10 View commit details
    Browse the repository at this point in the history