profiler: upgrade gostackparse to support Go 1.21 tracebacks #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2023-09-05 14:42:40 Comparing candidate commit 63a44e8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
3 tasks
|
This wasn't actually fixed by #2171. v0.6.0 doesn't include the needed changes |
5 tasks
5 tasks
Go 1.21 will change stack traces to include the ID of the parent goroutine in a goroutine's stack trace, e.g. goroutine 18 [running]: < ... stack frames ... > created by main.main in goroutine 1 (see go.dev/cl/435337). Upgrade gostackparse, used by the goroutines wait profile, to handle this change so that "in goroutine N" doesn't appear in the profile.
nsrip-dd
force-pushed
the
nick.ripley/upgrade-gostackparse
branch
from
9fd5f9c
to
63a44e8
Compare
darccio
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrades our gostackparse dependency to pick up commit 3d65ba9.
Motivation
Go 1.21 will change stack traces to include the ID of the parent
goroutine in a goroutine's stack trace, e.g.
(see go.dev/cl/435337). Unless we upgrade, we'll see
"in goroutine 1" in the root frames in the goroutines wait
profile.
Describe how to test/QA your changes
This is picking up a change which is already tested in the upstream library.
Reviewer's Checklist