Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracer: Check for nil interface types in span.Finish(WithError()) #2036

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

tracer: Check for nil interface types in span.Finish(WithError()) #2036

wants to merge 12 commits into from

Commits on Jun 12, 2023

  1. tracer: Check for nil interface types in span.Finish(WithError())

    @ajgajg1134
    ajgajg1134 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    2a0f38c View commit details
    Browse the repository at this point in the history

  2. tracer: move reflect nil error check to WithError to never set a bad … 

    …nil value
    @ajgajg1134
    ajgajg1134 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    ca97dad View commit details
    Browse the repository at this point in the history

  3. tracer: check for invalid reflection before checking is nil

    @ajgajg1134
    ajgajg1134 committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    a58099a View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. Only check for nil on pointers

    @ajgajg1134
    ajgajg1134 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    6e60ae7 View commit details
    Browse the repository at this point in the history

  2. Add comment

    @ajgajg1134
    ajgajg1134 committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4524032 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. Merge branch 'main' into andrew.glaude/nilSpanError

    @katiehockman
    katiehockman committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    bd5eaca View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Update ddtrace/tracer/option.go

    @ajgajg1134
    ajgajg1134 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    126e62c View commit details
    Browse the repository at this point in the history

  2. Add debug log for nil pointer under error

    @ajgajg1134
    ajgajg1134 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    5621912 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Merge branch 'main' into andrew.glaude/nilSpanError

    @ajgajg1134
    ajgajg1134 committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e6dfa2e View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge branch 'main' into andrew.glaude/nilSpanError

    @ajgajg1134
    ajgajg1134 committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    701a3ee View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Update benchmark to also have error, make comments more readable

    @ajgajg1134
    ajgajg1134 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b76458d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into andrew.glaude/nilSpanError

    @katiehockman
    katiehockman committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    f5901b4 View commit details
    Browse the repository at this point in the history