Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/google.golang.org/grpc: stop using deprecated packages #1959

Merged
merged 12 commits into from Aug 31, 2023

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented May 4, 2023

What does this PR do?

Stop using the following dependencies for contrib/google.golang.org/grpc:

  • github.com/golang/protobuf/proto
  • golang.org/x/net/context
  • github.com/golang/protobuf/jsonpb

Motivation

These packages are deprecated or have alternatives.
Partially solves #1136

Describe how to test/QA your changes

Reviewer's Checklist

  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@pr-commenter
Copy link

pr-commenter bot commented May 4, 2023

Benchmarks

Benchmark execution time: 2023-08-31 12:06:20

Comparing candidate commit fd57745 in PR branch rarguelloF/remove-deprecated-deps-grpc with baseline commit 16c1f8b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics.

@rarguelloF rarguelloF marked this pull request as ready for review May 26, 2023 14:58
@rarguelloF rarguelloF requested a review from a team as a code owner May 26, 2023 14:58
@rarguelloF rarguelloF requested a review from a team May 26, 2023 14:58
@rarguelloF rarguelloF merged commit aa14b02 into main Aug 31, 2023
368 of 384 checks passed
@rarguelloF rarguelloF deleted the rarguelloF/remove-deprecated-deps-grpc branch August 31, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants