Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: introduce continuous smoke testing #1611

Merged
merged 8 commits into from Dec 8, 2022
Merged

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Dec 7, 2022

What does this PR do?

Introduce a github workflow to run "smoke tests" whose goal is to very simply check that dd-trace-go works (eg. compiling only) under some given conditions/environments.

I bootstrapped it with a smoke test of dd-trace-go after the go.mod file got updated with go get -u where we basically expect our core packages (tracer, profiler and appsec) to still compile and work after a new minor release of our dependencies.

Motivation

  1. Uncover go get -u issues on new go.mod deps before releasing.
    Related to [BUG] v1.44.0 seems to pull in a broken pkg #1607
  2. Uncover go get -u issues on existing go.mod deps when a new breaking change has been introduced in one of our unstable (v0) dependencies

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner December 7, 2022 22:48
@Julio-Guerra Julio-Guerra added this to the v1.45.0 milestone Dec 7, 2022
@pr-commenter
Copy link

pr-commenter bot commented Dec 7, 2022

Benchmarks

Comparing candidate commit ab1dca8 in PR branch julio.guerra/smoke-tests with baseline commit 0ab9332 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Julio-Guerra Julio-Guerra added the ci label Dec 7, 2022
@Julio-Guerra
Copy link
Contributor Author

I temporarily enabled the workflow on pull requests to see it working at https://github.com/DataDog/dd-trace-go/actions/runs/3643501586/jobs/6151789596 and it properly detects the go get -u issue we currently have

Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would prefer a better name.

@@ -0,0 +1,34 @@
name: Smoke Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why isn't this called "go get -u test" or something similar?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm expecting to put more smoke tests cases as jobs of this workflow.
The next one I have in mind is go mod vendor where we used to have many issues in the past (mostly before go modules existed ^^') where some files were not vendored and it was leading to compilation issues too.

@Julio-Guerra Julio-Guerra merged commit 3983e27 into main Dec 8, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/smoke-tests branch December 8, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants