New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: introduce continuous smoke testing #1611
Conversation
I temporarily enabled the workflow on pull requests to see it working at https://github.com/DataDog/dd-trace-go/actions/runs/3643501586/jobs/6151789596 and it properly detects the go get -u issue we currently have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would prefer a better name.
@@ -0,0 +1,34 @@ | |||
name: Smoke Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why isn't this called "go get -u test" or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm expecting to put more smoke tests cases as jobs of this workflow.
The next one I have in mind is go mod vendor
where we used to have many issues in the past (mostly before go modules existed ^^') where some files were not vendored and it was leading to compilation issues too.
What does this PR do?
Introduce a github workflow to run "smoke tests" whose goal is to very simply check that dd-trace-go works (eg. compiling only) under some given conditions/environments.
I bootstrapped it with a smoke test of dd-trace-go after the go.mod file got updated with
go get -u
where we basically expect our core packages (tracer, profiler and appsec) to still compile and work after a new minor release of our dependencies.Motivation
go get -u
issues on new go.mod deps before releasing.Related to [BUG] v1.44.0 seems to pull in a broken pkg #1607
go get -u
issues on existing go.mod deps when a new breaking change has been introduced in one of our unstable (v0) dependenciesDescribe how to test/QA your changes
Reviewer's Checklist
Triage
milestone is set.