Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a nightly govulncheck workflow #1599

Merged
merged 66 commits into from Dec 6, 2022
Merged

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

Motivation

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@dianashevchenko dianashevchenko requested a review from a team as a code owner November 29, 2022 10:09
@dianashevchenko dianashevchenko added this to the Triage milestone Nov 29, 2022
@DataDog DataDog deleted a comment from pr-commenter bot Nov 29, 2022
@DataDog DataDog deleted a comment from pr-commenter bot Nov 29, 2022
@DataDog DataDog deleted a comment from pr-commenter bot Nov 29, 2022
@DataDog DataDog deleted a comment from pr-commenter bot Nov 29, 2022
@pr-commenter

This comment has been minimized.

1 similar comment
@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@dianashevchenko dianashevchenko force-pushed the shevchenko/govulncheck branch 2 times, most recently from 76103cf to 40208f9 Compare December 1, 2022 13:27
@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@DataDog DataDog deleted a comment from pr-commenter bot Dec 5, 2022
@DataDog DataDog deleted a comment from pr-commenter bot Dec 5, 2022
@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2022

Benchmarks

Found 0 performance improvements and 1 performance regressions! Performance is the same for 5 cases.

@dianashevchenko dianashevchenko changed the title [WIP]: Adding a nightly govulncheck workflow Adding a nightly govulncheck workflow Dec 6, 2022
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This will be helpful.

path=./appsec/... check_results
path=./internal/... check_results
path=./profiler/... check_results
exit $found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: newline at the end

@dianashevchenko dianashevchenko merged commit 9dfd1b5 into main Dec 6, 2022
@dianashevchenko dianashevchenko deleted the shevchenko/govulncheck branch December 6, 2022 16:08
@knusbaum knusbaum modified the milestones: Triage, v1.44.0, v1.45.0 Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants