Add pipeline to upload benchmark samples to S3 #1595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
This PR enables a way to upload your benchmark results to S3 bucket.
Successful jobs:
https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-go/-/jobs/197504283
https://gitlab.ddbuild.io/DataDog/apm-reliability/relenv-microbenchmarking-platform/-/jobs/197505955
Screenshot of S3 bucket:
Motivation
We can't apply changes to S3 bucket permissions for you during production freeze that will last till December 5th.
Realizing that you may want to have fast & dirty solution to upload to S3, I implemented this PR and relevant changes in https://github.com/DataDog/relenv-microbenchmarking-platform/tree/ddyurchenko/temp-s3-uploader. There are couple of downsides to this setup, but at least it should allow you to store your benchmarks results that we can import into Benchmarking Platform dashboard and visualize history.
As soon as freeze ends, we can remove temporary fix and move forward with standard solution.