tracer: support b3multi alias for b3 carrier
#1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiehockman
changed the title
b3multi alias for b3 carrier
katiehockman
changed the title
b3multi alias for b3 carrierb3multi alias for b3 carrier
ajgajg1134
requested changes
Nov 22, 2022
Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
BenchmarksFound 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds b3multi as a supported propagator for trace context extraction and injection, which will act as a new alias for the existing b3 propagator.
Motivation
This is to align with the OTel specification.
Describe how to test/QA your changes
Set
DD_PROPAGATION_STYLE_INJECTandDD_PROPAGATION_STYLE_EXTRACTto"b3"and ensure that any headers headers propagate as expected. Then do the same for setting it to"b3multi"and verify that the behavior didn't change.Reviewer's Checklist
Triagemilestone is set.