appsec: fix libddwaf stripping on macOS #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hellzy
force-pushed
the
fix-libddwaf-stripping
branch
from
03bba7c
to
6e1363f
Compare
Julio-Guerra
force-pushed
the
fix-libddwaf-stripping
branch
from
6e1363f
to
e843a9e
Compare
Hellzy
approved these changes
Sep 26, 2022
Julio-Guerra
added a commit
that referenced
this pull request
Sep 26, 2022
Co-authored-by: François Mazeau <francois.mazeau@datodoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to let libddwaf's CI strip the libddwaf.a file for us from their CI in DataDog/libddwaf#107 so we avoid running the binutils
stripon it as it seems not to handle the compact unwinding information properly.Fixes #1478