ddtrace: support tracer.SetUser on a mockspan #1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracer.SetUser() was specific to the *tracer.span type and therefore was not working with the mockup span. To be able to use tracer.SetUser() on the mockup span type, we propose to implement its behaviour through the now exported `SetUser()` method of the span struct types. tracer.SetUser() does a type-assertion to check this method is present and delegates its call to it. We can now provide a proper implementation for *mockspan.
ajgajg1134
approved these changes
Sep 28, 2022
Hellzy
pushed a commit
that referenced
this pull request
Sep 30, 2022
tracer.SetUser() was specific to the *tracer.span type and therefore was not working with the mockup span. To be able to use tracer.SetUser() on the mockup span type, we propose to implement its behaviour through the now exported `SetUser()` method of the span struct types. tracer.SetUser() does a type-assertion to check this method is present and delegates its call to it. We can now provide a proper implementation for *mockspan. Co-authored-by: Andrew Glaude <andrew.glaude@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracer.SetUser()was specific to thetracer.spantype and therefore not working with the mockup span type.To be able to use
tracer.SetUser()on the mockup span type, this PR proposes to implement its behavior through the exportedSetUser()method of the span struct types so we can implement it once for any span type implementing this method.Fixes #1451