contrib/99designs/gqlgen: fix issue with example import in tests #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiehockman
approved these changes
Sep 2, 2022
|
Thanks @katiehockman ! Anything else needed from my end to get this merged in? |
katiehockman
approved these changes
Sep 2, 2022
|
It looks like your branch has fallen out-of-date, can you please merge the latest |
|
Of course! Just updated @ajgajg1134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1452
The example module referenced previously was moved to a different import recently. Thus, if your project tries to depend on
contrib/99designs/gqlgenyou'll end up with an error from being unable to import the example.This resolves that by updating the gqlgen version to a more recent version.
I didn't upgrade to the most recent version given the contribution guidelines for preferring older, more stable versions. Let me know if I should pick a more recent one!Update: I ended up moving to the most recent version since older versions were throwing errors withgo vet(see the initial commit for errors).