contrib/database/sql: Fix race condition when registering drivers #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Library failing when registering drivers in parallel on different goroutines.
Internal `driverRegistry` wasn't goroutine safe, causing race conditions with
multiple writes in the internal maps.
```
$ go test -race -run TestRegister
WARNING: DATA RACE
Write at 0x00c000254000 by goroutine 9:
runtime.mapaccessK()
/opt/homebrew/Cellar/go/1.19/libexec/src/runtime/map.go:518 +0x1ec
gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.(*driverRegistry).add()
/Users/rafael.justo/dev/go/src/github.com/rafaeljusto/dd-trace-go/contrib/database/sql/sql.go:60 +0x144
gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.TestRegister.func1()
/Users/rafael.justo/dev/go/src/github.com/rafaeljusto/dd-trace-go/contrib/database/sql/sql_test.go:282 +0x54
gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.TestRegister.func2()
/Users/rafael.justo/dev/go/src/github.com/rafaeljusto/dd-trace-go/contrib/database/sql/sql_test.go:285 +0x44
Previous write at 0x00c000254000 by goroutine 15:
runtime.mapaccessK()
/opt/homebrew/Cellar/go/1.19/libexec/src/runtime/map.go:518 +0x1ec
gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.(*driverRegistry).add()
/Users/rafael.justo/dev/go/src/github.com/rafaeljusto/dd-trace-go/contrib/database/sql/sql.go:60 +0x144
gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.TestRegister.func1()
/Users/rafael.justo/dev/go/src/github.com/rafaeljusto/dd-trace-go/contrib/database/sql/sql_test.go:282 +0x54
gopkg.in/DataDog/dd-trace-go.v1/contrib/database/sql.TestRegister.func2()
/Users/rafael.justo/dev/go/src/github.com/rafaeljusto/dd-trace-go/contrib/database/sql/sql_test.go:285 +0x44
```
knusbaum
requested changes
Sep 21, 2022
knusbaum
approved these changes
Sep 21, 2022
|
Looks like something is missing after
|
|
@rafaeljusto We can ignore those failures, as they don't run for outside contributions (we should really disable them). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library failing when registering drivers in parallel on different goroutines.
Internal
driverRegistrywasn't goroutine safe, causing race conditions with multiple writes in the internal maps.