Use span read lock when reading span meta from span context #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com:DataDog/dd-trace-go into alex.normand/fix-race-condition-span-context-meta
ajgajg1134
approved these changes
Aug 23, 2022
ajgajg1134
deleted the
alex.normand/fix-race-condition-span-context-meta
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a big oversight when I implemented #1226. Instead of using the span's mutex to protect the reading of the span's meta, I used the span context's mutex. This caused a race condition/panic when a concurrent goroutine called
trace.finishedOne.